diff --git a/Lib/test/test_xml_etree.py b/Lib/test/test_xml_etree.py index acb11615b35c0b..87f1972c722915 100644 --- a/Lib/test/test_xml_etree.py +++ b/Lib/test/test_xml_etree.py @@ -4339,6 +4339,53 @@ def test_treebuilder_elementfactory_none(self): e = parser.close() self._check_sample1_element(e) + def test_start_copies_attrs(self): + class DictSubclass(dict): + pass + + for dict_type in (dict, DictSubclass): + for initial in ({}, {'key': 'value'}): + for factory in (None, ET.Element): + with self.subTest(dict_type=dict_type, initial=initial, + factory=factory): + attrs = dict_type(initial) + tb = ET.TreeBuilder(element_factory=factory) + elem = tb.start('root', attrs) + tb.end('root') + self.assertIs(tb.close(), elem) + attrs.clear() + attrs['caller'] = 'changed' + self.assertEqual(elem.attrib, initial) + elem.set('element', 'changed') + self.assertEqual(attrs, {'caller': 'changed'}) + + def test_start_reuses_attrs(self): + tb = ET.TreeBuilder() + root = tb.start('root', {}) + attrs = {'id': 'first'} + tb.start('child', attrs) + tb.end('child') + attrs['id'] = 'second' + tb.start('child', attrs) + tb.end('child') + tb.end('root') + self.assertIs(tb.close(), root) + self.assertEqual([child.get('id') for child in root], + ['first', 'second']) + + def test_start_element_factory_attrs(self): + attrs = {'key': 'value'} + + def factory(tag, attrib): + self.assertIs(attrib, attrs) + return ET.Element(tag, attrib) + + tb = ET.TreeBuilder(element_factory=factory) + elem = tb.start('root', attrs) + tb.end('root') + self.assertIs(tb.close(), elem) + self.assertEqual(elem.attrib, attrs) + def test_subclass(self): class MyTreeBuilder(ET.TreeBuilder): def foobar(self, x): diff --git a/Misc/NEWS.d/next/Library/2026-11-16-15-50-00.gh-issue-80866.Km4pQ8.rst b/Misc/NEWS.d/next/Library/2026-11-16-15-50-00.gh-issue-80866.Km4pQ8.rst new file mode 100644 index 00000000000000..db1585a2d5cbfb --- /dev/null +++ b/Misc/NEWS.d/next/Library/2026-11-16-15-50-00.gh-issue-80866.Km4pQ8.rst @@ -0,0 +1,2 @@ +Fix :meth:`xml.etree.ElementTree.TreeBuilder.start` sharing the input attribute +dictionary with created elements when using the default element factory. diff --git a/Modules/_elementtree.c b/Modules/_elementtree.c index 2195010261678f..325d86ebc7a54e 100644 --- a/Modules/_elementtree.c +++ b/Modules/_elementtree.c @@ -3116,6 +3116,15 @@ _elementtree_TreeBuilder_start_impl(TreeBuilderObject *self, PyObject *tag, PyObject *attrs) /*[clinic end generated code: output=e7e9dc2861349411 input=26cccb49c3b8b12f]*/ { + if (!self->element_factory) { + attrs = PyDict_Copy(attrs); + if (attrs == NULL) { + return NULL; + } + PyObject *node = treebuilder_handle_start(self, tag, attrs); + Py_DECREF(attrs); + return node; + } return treebuilder_handle_start(self, tag, attrs); }