From 09129569489c98a2f7be4fd2f5213615b1943994 Mon Sep 17 00:00:00 2001 From: Alon Faraj Date: Tue, 10 Nov 2026 12:46:43 +0200 Subject: [PATCH 1/2] gh-161691: Fix use of released memoryview in comparison and 'c' item assignment --- Lib/test/test_memoryview.py | 16 +++++++++++++++- ...026-11-10-10-40-31.gh-issue-161691.1NTSrQ.rst | 2 ++ Objects/memoryobject.c | 6 ++++++ 3 files changed, 23 insertions(+), 1 deletion(-) create mode 100644 Misc/NEWS.d/next/Core_and_Builtins/2026-11-10-10-40-31.gh-issue-161691.1NTSrQ.rst diff --git a/Lib/test/test_memoryview.py b/Lib/test/test_memoryview.py index 283f0077d7ae932..9abe9a42c457083 100644 --- a/Lib/test/test_memoryview.py +++ b/Lib/test/test_memoryview.py @@ -769,7 +769,7 @@ def __buffer__(self, flags): _testcapi.clear_memoryview(view) return memoryview(data) - self.assertTrue(view == Other()) + self.assertFalse(view == Other()) with self.assertRaisesRegex(ValueError, "released"): view.tobytes() data.clear() @@ -996,6 +996,20 @@ def __bool__(self): m[0] = MyBool() self.assertEqual(ba[:8], b'\0'*8) + ba = None + m = memoryview(bytearray(b'\xff'*size)).cast('c') + with self.assertRaisesRegex(ValueError, "operation forbidden"): + m[MyIndex()] = b'x' + self.assertEqual(ba[:8], b'\0'*8) + + class MyBuffer: + def __buffer__(self, flags): + release() + return memoryview(b'\xff'*size) + ba = None + m = memoryview(bytearray(b'\xff'*size)) + self.assertFalse(m == MyBuffer()) + def test_buffer_reference_loop(self): m = memoryview(b'abc').__buffer__(0) o = MyObject() diff --git a/Misc/NEWS.d/next/Core_and_Builtins/2026-11-10-10-40-31.gh-issue-161691.1NTSrQ.rst b/Misc/NEWS.d/next/Core_and_Builtins/2026-11-10-10-40-31.gh-issue-161691.1NTSrQ.rst new file mode 100644 index 000000000000000..d1699882abe89fe --- /dev/null +++ b/Misc/NEWS.d/next/Core_and_Builtins/2026-11-10-10-40-31.gh-issue-161691.1NTSrQ.rst @@ -0,0 +1,2 @@ +Fix use of a released :class:`memoryview` in comparison and in item +assignment with format ``'c'`` when user code releases the view. diff --git a/Objects/memoryobject.c b/Objects/memoryobject.c index 11a0a7ab04f08bc..a28271b3c6f3389 100644 --- a/Objects/memoryobject.c +++ b/Objects/memoryobject.c @@ -2268,6 +2268,7 @@ pack_single(PyMemoryViewObject *self, char *ptr, PyObject *item, const char *fmt return type_error_int(fmt); if (PyBytes_GET_SIZE(item) != 1) return value_error_int(fmt); + CHECK_RELEASED_INT_AGAIN(self); *ptr = PyBytes_AS_STRING(item)[0]; break; @@ -3551,6 +3552,11 @@ memory_richcompare_pinned(PyObject *v, PyObject *w, int op) goto result; /* Py_NotImplemented */ } ww = &wbuf; + /* w.__buffer__() may have released v. */ + if (BASE_INACCESSIBLE(v)) { + equal = 0; + goto result; + } } if (!equiv_shape(vv, ww)) { From fda95ef2edcf66c3744fa4a16ca138609816c8fa Mon Sep 17 00:00:00 2001 From: Alon Faraj Date: Fri, 13 Nov 2026 13:48:08 +0200 Subject: [PATCH 2/2] Raise ValueError instead of returning not equal --- Lib/test/test_memoryview.py | 14 ++++---------- Objects/memoryobject.c | 4 +++- 2 files changed, 7 insertions(+), 11 deletions(-) diff --git a/Lib/test/test_memoryview.py b/Lib/test/test_memoryview.py index 9abe9a42c457083..ebb0de12b6f7c92 100644 --- a/Lib/test/test_memoryview.py +++ b/Lib/test/test_memoryview.py @@ -576,7 +576,8 @@ def __buffer__(self, flags): data.clear() return memoryview(data) - view == Other() + with self.assertRaisesRegex(ValueError, "released"): + view == Other() with self.assertRaisesRegex(ValueError, "released"): view.tobytes() data.clear() @@ -769,7 +770,8 @@ def __buffer__(self, flags): _testcapi.clear_memoryview(view) return memoryview(data) - self.assertFalse(view == Other()) + with self.assertRaisesRegex(ValueError, "released"): + view == Other() with self.assertRaisesRegex(ValueError, "released"): view.tobytes() data.clear() @@ -1002,14 +1004,6 @@ def __bool__(self): m[MyIndex()] = b'x' self.assertEqual(ba[:8], b'\0'*8) - class MyBuffer: - def __buffer__(self, flags): - release() - return memoryview(b'\xff'*size) - ba = None - m = memoryview(bytearray(b'\xff'*size)) - self.assertFalse(m == MyBuffer()) - def test_buffer_reference_loop(self): m = memoryview(b'abc').__buffer__(0) o = MyObject() diff --git a/Objects/memoryobject.c b/Objects/memoryobject.c index a28271b3c6f3389..36e70f62048bf99 100644 --- a/Objects/memoryobject.c +++ b/Objects/memoryobject.c @@ -3554,7 +3554,9 @@ memory_richcompare_pinned(PyObject *v, PyObject *w, int op) ww = &wbuf; /* w.__buffer__() may have released v. */ if (BASE_INACCESSIBLE(v)) { - equal = 0; + PyErr_SetString(PyExc_ValueError, + "operation forbidden on released memoryview object"); + equal = MV_COMPARE_EX; goto result; } }