diff --git a/Lib/test/test_memoryview.py b/Lib/test/test_memoryview.py index 283f0077d7ae932..ebb0de12b6f7c92 100644 --- a/Lib/test/test_memoryview.py +++ b/Lib/test/test_memoryview.py @@ -576,7 +576,8 @@ def __buffer__(self, flags): data.clear() return memoryview(data) - view == Other() + with self.assertRaisesRegex(ValueError, "released"): + view == Other() with self.assertRaisesRegex(ValueError, "released"): view.tobytes() data.clear() @@ -769,7 +770,8 @@ def __buffer__(self, flags): _testcapi.clear_memoryview(view) return memoryview(data) - self.assertTrue(view == Other()) + with self.assertRaisesRegex(ValueError, "released"): + view == Other() with self.assertRaisesRegex(ValueError, "released"): view.tobytes() data.clear() @@ -996,6 +998,12 @@ def __bool__(self): m[0] = MyBool() self.assertEqual(ba[:8], b'\0'*8) + ba = None + m = memoryview(bytearray(b'\xff'*size)).cast('c') + with self.assertRaisesRegex(ValueError, "operation forbidden"): + m[MyIndex()] = b'x' + self.assertEqual(ba[:8], b'\0'*8) + def test_buffer_reference_loop(self): m = memoryview(b'abc').__buffer__(0) o = MyObject() diff --git a/Misc/NEWS.d/next/Core_and_Builtins/2026-11-10-10-40-31.gh-issue-161691.1NTSrQ.rst b/Misc/NEWS.d/next/Core_and_Builtins/2026-11-10-10-40-31.gh-issue-161691.1NTSrQ.rst new file mode 100644 index 000000000000000..d1699882abe89fe --- /dev/null +++ b/Misc/NEWS.d/next/Core_and_Builtins/2026-11-10-10-40-31.gh-issue-161691.1NTSrQ.rst @@ -0,0 +1,2 @@ +Fix use of a released :class:`memoryview` in comparison and in item +assignment with format ``'c'`` when user code releases the view. diff --git a/Objects/memoryobject.c b/Objects/memoryobject.c index 11a0a7ab04f08bc..36e70f62048bf99 100644 --- a/Objects/memoryobject.c +++ b/Objects/memoryobject.c @@ -2268,6 +2268,7 @@ pack_single(PyMemoryViewObject *self, char *ptr, PyObject *item, const char *fmt return type_error_int(fmt); if (PyBytes_GET_SIZE(item) != 1) return value_error_int(fmt); + CHECK_RELEASED_INT_AGAIN(self); *ptr = PyBytes_AS_STRING(item)[0]; break; @@ -3551,6 +3552,13 @@ memory_richcompare_pinned(PyObject *v, PyObject *w, int op) goto result; /* Py_NotImplemented */ } ww = &wbuf; + /* w.__buffer__() may have released v. */ + if (BASE_INACCESSIBLE(v)) { + PyErr_SetString(PyExc_ValueError, + "operation forbidden on released memoryview object"); + equal = MV_COMPARE_EX; + goto result; + } } if (!equiv_shape(vv, ww)) {