Skip to content

Better constant narrowing in the JIT optimizer #130415

Closed

Description

@brandtbucher

Please don't work on this. I'm planning on sprinting on this with new contributors at an event this weekend.

Currently, the JIT optimizer uses the _COMPARE_OP family, _CONTAINS_OP, _IS_OP, and the _TO_BOOL family to narrow the types of the input values and the type of the output value.

However, by "peeking ahead" and seeing how a value will be used, we can narrow these types to constants as well. As a simple example, consider _TO_BOOL_INT + _GUARD_IS_FALSE_CHECK on an unknown value. After the _TO_BOOL_INT, it can be narrowed to a known class, int (we do this today). However, after the _GUARD_IS_FALSE_CHECK, we can actually narrow it to a constant value, 0.

An example implementation of this idea for _TO_BOOL_BOOL is here: main...brandtbucher:cpython:hack-night-to-bool-bool
 
I've divided this work into 3 "waves" of increasing complexity. Tasks in bold are probably a bit harder, tasks in italics are probably a bit easier.

Narrow types to constants in branches involving truthiness:

  • _TO_BOOL + _GUARD_IS_*_POP gh-130659
  • _TO_BOOL_BOOL + _GUARD_IS_*_POP gh-130659
  • _TO_BOOL_INT + _GUARD_IS_*_POP gh-130772
  • _TO_BOOL_LIST + _GUARD_IS_*_POP
  • _TO_BOOL_STR + _GUARD_IS_*_POP gh-130476

Narrow types to constants in branches involving comparisons with a constant:

Evaluate comparisons involving two constants:

This is related, but a bit more involved, since we need a way to pop two values from the stack and push a constant (_POP_TWO_LOAD_CONST_INLINE_BORROW). We should also teach remove_unneeded_uops about this new instruction.

  • _COMPARE_OP (==, !=, <, >, <=, >=)
  • _COMPARE_OP_FLOAT (==, !=, <, >, <=, >=) gh-137062
  • _COMPARE_OP_INT (==, !=, <, >, <=, >=) gh-131489
  • _COMPARE_OP_STR (==, !=, <, >, <=, >=) gh-137062
  • _CONTAINS_OP (in, not in)
  • _IS_OP (is, is not)

Linked PRs

Activity

  1. added 3 commits that reference this issue on Mar 2, 2025
  2. added 2 commits that reference this issue on Mar 21, 2025
  3. tomasr8 commented on Mar 30, 2025

    @tomasr8
    Member

    Hi @brandtbucher! Are any of the tasks up for grabs still? I haven't worked on the JIT before, but I'd like to try :)

  4. picnixz commented on Mar 30, 2025

    @picnixz
    Member

    @tomasr8 I've updated the issue with the related PRs and what they were solving so you have enough tasks to pick up I think :')

  5. added a commit that references this issue on Apr 1, 2025
  6. brandtbucher commented on Apr 3, 2025

    @brandtbucher
    MemberAuthor

    Thanks for your interest, @tomasr8! I think we actually may have some good issues over on GH-131798.

    Would you like to add a case to optimizer_bytecodes.c for _CONTAINS_OP_SET, which sets the output type to &PyBool_Type? That way, the JIT knows that code like foo in some_set returns a bool. It should look just like the existing handler for _CONTAINS_OP. (Don't forget to run make regen-cases!)

    This allows the JIT to automatically remove an unnecessary _TO_BOOL_BOOL instruction when people do condition = foo in some_set; if condition: .... The test for this should probably look something like test_compare_pop_two_load_const_inline_borrow, except you'll need to write a new testfunc and assert that _CONTAINS_OP_SET is in the uops, but _TO_BOOL_BOOL isn't. The latter check should fail before your change, and pass after.

    Let me know if you start working on it, and feel free to ping me anywhere (here, Discord, email) if you get stuck.

  7. tomasr8 commented on Apr 3, 2025

    @tomasr8
    Member

    Would you like to add a case to optimizer_bytecodes.c for _CONTAINS_OP_SET, which sets the output type to &PyBool_Type?

    Sounds good! I will take a look :) Thanks for the detailed explanation of the issue, that is super helpful and it's pretty clear to me now what I need to do.

  8. added a commit that references this issue on Apr 21, 2025
  9. Fidget-Spinner commented on May 19, 2025

    @Fidget-Spinner
    Member

    I think we should pause this for now until #132733 is merged. Adding constant propagation code is error-prone and tedious. With that PR, contributors can just mark a bytecode as pure and get it for free for everything. Then we could just add more to the cases generator to improve on the constant propagation code, rather than writing it manually ourselves.

  10. brandtbucher commented on Jun 6, 2025

    @brandtbucher
    MemberAuthor

    That makes sense for the third category ("evaluate comparisons involving two constants"). The second category ("narrow types to constants in branches involving comparisons with a constant") is probably still worth doing, but will require some new symbolic values to represent equality and inequality (similar to the new truthiness symbols).

  11. Fidget-Spinner commented on Jun 27, 2025

    @Fidget-Spinner
    Member

    I think we should pause this for now until #132733 is merged. Adding constant propagation code is error-prone and tedious. With that PR, contributors can just mark a bytecode as pure and get it for free for everything. Then we could just add more to the cases generator to improve on the constant propagation code, rather than writing it manually ourselves.

    This PR is landed. So things are no longer blocked!

  12. savannahostrowski commented on Sep 18, 2025

    @savannahostrowski
    Member

    Just crossed out IS_OP since @brandtbucher and I had discussed this and decided it was too complicated to handle.

  13. added a commit that references this issue on Jan 22, 2026
  14. added a commit that references this issue on Jan 24, 2026
  15. Fidget-Spinner commented on Jan 24, 2026

    @Fidget-Spinner
    Member

    _COMPARE_OP is a little difficult as it's an overloaded op, and can call arbitrary Python code.

    _CONTAINS_OP as well.

    Thanks to @reidenong , we completed IS_OP and COMPARE_OP_(TYPE). In the future, when we start recording types/values, we can narrow the LHS if its comparison is side-effect free #144179

    This issue is done. Thanks everyone!

  16. added 2 commits that reference this issue on Feb 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

interpreter-core(Objects, Python, Grammar, and Parser dirs)performancePerformance or resource usagetopic-JITtype-featureA feature request or enhancement

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions