Skip to content

Commit 715d34f

Browse files
authored
gh-162170: Makefile: have "install" depend on pgo (#95287)
Previously, `make install` would ignore PGO. This isn't an issue if one runs `make && make install`, since `make` will build with pgo (if requested) and then `make install` won't rebuild anything. But if one simply does `./configure --enable-optimizations && make install`, the build system would build a non-PGO build and then install that. This commit changes the Makefile so that `install` depends on `all`, which includes PGO when requested.
1 parent e28063e commit 715d34f

2 files changed

Lines changed: 4 additions & 1 deletion

File tree

‎Makefile.pre.in‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2485,7 +2485,7 @@ sharedinstall: all
24852485
# Install the interpreter with $(VERSION) affixed
24862486
# This goes into $(exec_prefix)
24872487
.PHONY: altbininstall
2488-
altbininstall: $(BUILDPYTHON) @FRAMEWORKPYTHONW@
2488+
altbininstall: all @FRAMEWORKPYTHONW@
24892489
@for i in $(BINDIR) $(LIBDIR); \
24902490
do \
24912491
if test ! -d $(DESTDIR)$$i; then \
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
``make install`` now depends on the ``all`` target, so running it directly
2+
after ``./configure --enable-optimizations`` installs the PGO-optimized
3+
interpreter rather than an unoptimized build.

0 commit comments

Comments
 (0)