Skip to content

Commit 3941b24

Browse files
gh-91601: Use host addresses for IP interface reverse DNS names
1 parent 3ad9316 commit 3941b24

3 files changed

Lines changed: 28 additions & 0 deletions

File tree

‎Lib/ipaddress.py‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1538,6 +1538,9 @@ def __hash__(self):
15381538
def ip(self):
15391539
return IPv4Address(self._ip)
15401540

1541+
def _reverse_pointer(self):
1542+
return self.ip.reverse_pointer
1543+
15411544
@property
15421545
def with_prefixlen(self):
15431546
return '%s/%s' % (self._string_from_ip_int(self._ip),
@@ -2343,6 +2346,9 @@ def __hash__(self):
23432346
def ip(self):
23442347
return IPv6Address(self._ip)
23452348

2349+
def _reverse_pointer(self):
2350+
return self.ip.reverse_pointer
2351+
23462352
@property
23472353
def with_prefixlen(self):
23482354
return '%s/%s' % (self._string_from_ip_int(self._ip),

‎Lib/test/test_ipaddress.py‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2852,6 +2852,25 @@ def testReversePointer(self):
28522852
addr = ipaddress.IPv6Address(addr_v6)
28532853
self.assertEqual(addr.reverse_pointer, expected)
28542854

2855+
def testReversePointerInterface(self):
2856+
cases = [
2857+
('192.0.2.1', '1.2.0.192.in-addr.arpa', (0, 24, 32)),
2858+
('4321:0:1:2:3:4:567:89ab',
2859+
'b.a.9.8.7.6.5.0.4.0.0.0.3.0.0.0.'
2860+
'2.0.0.0.1.0.0.0.0.0.0.0.1.2.3.4.ip6.arpa', (0, 64, 128)),
2861+
('4321:0:1:2:3:4:567:89ab%eth0',
2862+
'b.a.9.8.7.6.5.0.4.0.0.0.3.0.0.0.'
2863+
'2.0.0.0.1.0.0.0.0.0.0.0.1.2.3.4.ip6.arpa', (0, 64, 128)),
2864+
('::ffff:192.0.2.1',
2865+
'1.0.2.0.0.0.0.c.f.f.f.f.0.0.0.0.'
2866+
'0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.ip6.arpa', (0, 96, 128)),
2867+
]
2868+
for address, expected, prefixes in cases:
2869+
for prefix in prefixes:
2870+
with self.subTest(address=address, prefix=prefix):
2871+
interface = ipaddress.ip_interface(f'{address}/{prefix}')
2872+
self.assertEqual(interface.reverse_pointer, expected)
2873+
28552874
def testIntRepresentation(self):
28562875
self.assertEqual(16909060, int(self.ipv4_address))
28572876
self.assertEqual(42540616829182469433547762482097946625,
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
Fix :attr:`~ipaddress.IPv4Address.reverse_pointer` on
2+
:class:`ipaddress.IPv4Interface` and :class:`ipaddress.IPv6Interface` to use
3+
the host address without the network prefix.

0 commit comments

Comments
 (0)