Skip to content

Commit 3756127

Browse files
committed
up
1 parent 441c010 commit 3756127

1 file changed

Lines changed: 8 additions & 14 deletions

File tree

‎Modules/mmapmodule.c‎

Lines changed: 8 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1567,22 +1567,16 @@ mmap_subscript_impl(mmap_object *self, PyObject *item)
15671567
else if (step == 1)
15681568
return _safe_PyBytes_FromStringAndSize(self->data + start, slicelen);
15691569
else {
1570-
char *result_buf = (char *)PyMem_Malloc(slicelen);
1571-
PyObject *result;
1572-
1573-
if (result_buf == NULL)
1574-
return PyErr_NoMemory();
1575-
1576-
if (safe_copy_to_slice(result_buf, self->data, start, step,
1577-
slicelen) < 0)
1578-
{
1579-
result = NULL;
1570+
PyBytesWriter *writer = PyBytesWriter_Create(slicelen);
1571+
if (writer == NULL) {
1572+
return NULL;
15801573
}
1581-
else {
1582-
result = PyBytes_FromStringAndSize(result_buf, slicelen);
1574+
if (safe_copy_to_slice(PyBytesWriter_GetData(writer), self->data,
1575+
start, step, slicelen) < 0) {
1576+
PyBytesWriter_Discard(writer);
1577+
return NULL;
15831578
}
1584-
PyMem_Free(result_buf);
1585-
return result;
1579+
return PyBytesWriter_Finish(writer);
15861580
}
15871581
}
15881582
else {

0 commit comments

Comments
 (0)