Skip to content

Commit 0b47fe1

Browse files
committed
Use context manager so resources are closed
1 parent 138c8ca commit 0b47fe1

1 file changed

Lines changed: 14 additions & 14 deletions

File tree

‎Tools/ssl/multissltests.py‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -277,9 +277,9 @@ def _download_src(self):
277277
url = url_template.format(v=self.version, s=self.short_version)
278278
log.info(f"Downloading from {url}")
279279
try:
280-
req = urlopen(url)
281-
# KISS, read all, write all
282-
data = req.read()
280+
with urlopen(url) as req:
281+
# KISS, read all, write all
282+
data = req.read()
283283
except HTTPError as e:
284284
log.error(
285285
f"Download from {url} has from failed: {e}"
@@ -300,19 +300,19 @@ def _unpack_src(self):
300300
shutil.rmtree(self.build_dir)
301301
os.makedirs(self.build_dir)
302302

303-
tf = tarfile.open(self.src_file)
304303
name = self.build_template.format(self.version)
305304
base = name + '/'
306-
# force extraction into build dir
307-
members = tf.getmembers()
308-
for member in list(members):
309-
if member.name == name:
310-
members.remove(member)
311-
elif not member.name.startswith(base):
312-
raise ValueError(member.name, base)
313-
member.name = member.name[len(base):].lstrip('/')
314-
log.info(f"Unpacking files to {self.build_dir}")
315-
tf.extractall(self.build_dir, members, filter='data')
305+
with tarfile.open(self.src_file) as tf:
306+
# force extraction into build dir
307+
members = tf.getmembers()
308+
for member in list(members):
309+
if member.name == name:
310+
members.remove(member)
311+
elif not member.name.startswith(base):
312+
raise ValueError(member.name, base)
313+
member.name = member.name[len(base):].lstrip('/')
314+
log.info(f"Unpacking files to {self.build_dir}")
315+
tf.extractall(self.build_dir, members, filter='data')
316316

317317
def _build_src(self, config_args=()):
318318
"""Now build openssl"""

0 commit comments

Comments
 (0)