Skip to content

Commit 083d251

Browse files
kmodmiss-islington
authored andcommitted
gh-162170: Makefile: have "install" depend on pgo (GH-95287)
Previously, `make install` would ignore PGO. This isn't an issue if one runs `make && make install`, since `make` will build with pgo (if requested) and then `make install` won't rebuild anything. But if one simply does `./configure --enable-optimizations && make install`, the build system would build a non-PGO build and then install that. This commit changes the Makefile so that `install` depends on `all`, which includes PGO when requested. (cherry picked from commit 715d34f) Co-authored-by: Kevin Modzelewski <kmod@users.noreply.github.com>
1 parent 8b898f5 commit 083d251

2 files changed

Lines changed: 4 additions & 1 deletion

File tree

‎Makefile.pre.in‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2496,7 +2496,7 @@ sharedinstall: all
24962496
# Install the interpreter with $(VERSION) affixed
24972497
# This goes into $(exec_prefix)
24982498
.PHONY: altbininstall
2499-
altbininstall: $(BUILDPYTHON) @FRAMEWORKPYTHONW@
2499+
altbininstall: all @FRAMEWORKPYTHONW@
25002500
@for i in $(BINDIR) $(LIBDIR); \
25012501
do \
25022502
if test ! -d $(DESTDIR)$$i; then \
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
``make install`` now depends on the ``all`` target, so running it directly
2+
after ``./configure --enable-optimizations`` installs the PGO-optimized
3+
interpreter rather than an unoptimized build.

0 commit comments

Comments
 (0)