From 19c5fd920155447dbfbc931843d52973966ba0ce Mon Sep 17 00:00:00 2001 From: Douglas Barker Date: Sat, 10 Oct 2026 12:53:42 -0400 Subject: [PATCH 1/3] enable the bugprone-unhandled-exception-at-new check --- .clang-tidy | 1 - 1 file changed, 1 deletion(-) diff --git a/.clang-tidy b/.clang-tidy index 66c9eb68b2..aa6164e27f 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -16,7 +16,6 @@ Checks: > -bugprone-implicit-widening-of-multiplication-result, -bugprone-inc-dec-in-conditions, -bugprone-unchecked-optional-access, - -bugprone-unhandled-exception-at-new, google-*, -google-build-using-namespace, -google-default-arguments, From 66383892f8fd269587f32cd28f95741f1fa0bee5 Mon Sep 17 00:00:00 2001 From: Douglas Barker Date: Sat, 10 Oct 2026 17:02:51 -0400 Subject: [PATCH 2/3] add changelog entry and reset clang-tidy warning limits --- .github/workflows/clang-tidy.yaml | 4 ++-- CHANGELOG.md | 3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/clang-tidy.yaml b/.github/workflows/clang-tidy.yaml index af5889a25b..b98aff7718 100644 --- a/.github/workflows/clang-tidy.yaml +++ b/.github/workflows/clang-tidy.yaml @@ -17,9 +17,9 @@ jobs: matrix: include: - cmake_options: all-options-abiv1-preview - warning_limit: 73 + warning_limit: 209 - cmake_options: all-options-abiv2-preview - warning_limit: 76 + warning_limit: 223 env: CC: /usr/bin/clang-22 CXX: /usr/bin/clang++-22 diff --git a/CHANGELOG.md b/CHANGELOG.md index 97cde89252..b73361b912 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -62,6 +62,9 @@ Increment the: to compile standalone on newer standard library implementations. [#4574](https://github.com/open-telemetry/opentelemetry-cpp/pull/4574) +* [CI] Enable the bugprone-unhandled-exception-at-new check + [#4689](https://github.com/open-telemetry/opentelemetry-cpp/pull/4689) + * [EXPORTER ETW] Fix `PropertyValue` string conversions that pre-sized a `vector` then `push_back`'d (doubling length) and that built `std::string` from `string_view::data()` without using the view length From 663be451d5ee35c4f876c6be91793aa2b40adf4f Mon Sep 17 00:00:00 2001 From: Marc Alff Date: Sun, 11 Oct 2026 23:43:46 +0200 Subject: [PATCH 3/3] Apply batched suggestions from code review Co-authored-by: Marc Alff --- .github/workflows/clang-tidy.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/clang-tidy.yaml b/.github/workflows/clang-tidy.yaml index 49a7ef7ded..7cf6f9e195 100644 --- a/.github/workflows/clang-tidy.yaml +++ b/.github/workflows/clang-tidy.yaml @@ -17,9 +17,9 @@ jobs: matrix: include: - cmake_options: all-options-abiv1-preview - warning_limit: 209 + warning_limit: 205 - cmake_options: all-options-abiv2-preview - warning_limit: 223 + warning_limit: 219 env: CC: /usr/bin/clang-22 CXX: /usr/bin/clang++-22