From 74e2f4da5fd25763d77998821544079d14e75332 Mon Sep 17 00:00:00 2001 From: Michael Uloth Date: Mon, 16 Nov 2026 22:07:10 -0500 Subject: [PATCH 01/19] skills/review-pr-comments-converge: skip feedback already answered #262 A second run of review-pr-comments-converge re-validated every comment on the PR and drafted a reply to each, including feedback an earlier run had already answered. The fetch output did not show the PR author, edit times or who resolved a thread, so a run could not tell. fetch_pr_comments.py now asks for the viewer, the PR author, who resolved each thread, and each post's state and times in the same request. Before printing, it gives every review body, inline thread and conversation comment one verdict: answered with its evidence, not answered, or not feedback because only the PR author or the gh login wrote it. It prints a "# Answerers:" line and one "answered" line per item, and exits 1 with a sentence when a time, a comment state or the viewer cannot be read. Times compare as datetimes, a same-second tie counts as new feedback, and a deleted account never answers and no longer crashes the REPLIES lines. SKILL.md puts every item not marked "no" on the decided list before validation, lists it under "Already answered" with its evidence, and reports "Nothing unanswered" when nothing is left. The check before posting compares fresh and saved answered lines, so a skip is read from the PR each time and never carried over. --- .../review-pr-comments-converge/SKILL.md | 58 +- .../scripts/fetch_pr_comments.py | 434 ++++++- .../scripts/test_fetch_pr_comments.py | 1046 ++++++++++++++++- 3 files changed, 1484 insertions(+), 54 deletions(-) diff --git a/tools/agents/config/skills/review-pr-comments-converge/SKILL.md b/tools/agents/config/skills/review-pr-comments-converge/SKILL.md index 0ff860a2..dedc25fb 100644 --- a/tools/agents/config/skills/review-pr-comments-converge/SKILL.md +++ b/tools/agents/config/skills/review-pr-comments-converge/SKILL.md @@ -79,9 +79,22 @@ prose such as a review body names that author, on the same rule: `@login` for a `BOT_NAMES` name for a bot, `a deleted account` for a deleted one, and `UNKNOWN` wherever `thank` shows it. +Each review with a body, each inline thread and each conversation comment also shows +**`answered`**, judged from the PR as it stands at this fetch. The **`# Answerers:`** line under +`# Source:` names the accounts whose posts count as answers: the PR's author and the gh login +running the fetch. A deleted account never counts. + +- `yes (...)` names the evidence that counted: `resolved by `, `reply by at +