diff --git a/README.md b/README.md index 348ce7c5..69563f7c 100644 --- a/README.md +++ b/README.md @@ -71,8 +71,12 @@ parallelism and isn't. [review-pr-comments-converge](./tools/agents/config/skills/review-pr-comments-converge/SKILL.md) does the same for reviewer feedback, and doesn't take the reviewer's word for it either: each comment is checked against the current code and marked valid, stale or mistaken before anything -acts on it. What gets fixed automatically and what gets escalated turns on one question, does -applying this require the author to make a choice. +acts on it. Feedback already answered is skipped and listed with the evidence that counted as +its answer, so a later run doesn't reply twice: a thread its one reviewer resolved, a thread whose +newest comment is an answerer's reply, or a top-level post naming the reviewer, where an answerer +is the PR author or the account running the skill. What gets fixed automatically and what gets +escalated +turns on one question, does applying this require the author to make a choice. [prove-it-works](./tools/agents/config/skills/prove-it-works/SKILL.md) proves or disproves a claim about the running system, given one sentence naming the claim or a PR, commit or URL. It sets the diff --git a/tools/agents/config/skills/review-code/SKILL.md b/tools/agents/config/skills/review-code/SKILL.md index ab38c10e..05f949b0 100644 --- a/tools/agents/config/skills/review-code/SKILL.md +++ b/tools/agents/config/skills/review-code/SKILL.md @@ -94,15 +94,17 @@ uv run /../review-pr-comments-converge/scripts/fetch_pr_comments ``` It prints every review, every inline thread with its replies, and every PR conversation comment, -which is where some bots post their reviews. A default `gh pr view` shows none of these. Save the -output to a file in a new `mktemp -d` directory, with the PR's reviews from +which is where some bots post their reviews. A default `gh pr view` shows none of these. Its +`# Answerers:` and `answered` lines name the PR author and the gh login running the fetch as +answerers, so items only answerers wrote print `n/a (yours)`, but a thread a third party joined does +not. This skill's reconciliation does not use these lines: its own "answered" verdict is separate. +Save the output to a file in a new `mktemp -d` directory, with the PR's reviews from `gh pr view -R / --json reviews` beside it, since the fetch helper leaves out a review with no body and no comments, such as a bare approval. With the reviewed head, these are the -**saved state** that Step 5 compares with the PR before posting. -Keep the output in this session for Step 4 and out of every agent's prompt and the Step 2 intent -block: an agent handed an earlier verdict tends to return it confirmed, and the point of this -review is a read that isn't anchored on anyone else's. The one exception is a dry run that CI -posted, which Step 2 carries to the agents. +**saved state** that Step 5 compares with the PR before posting. Keep the output in this session for +Step 4 and out of every agent's prompt and the Step 2 intent block: an agent handed an earlier +verdict tends to return it confirmed, and the point of this review is a read that isn't anchored on +anyone else's. The one exception is a dry run that CI posted, which Step 2 carries to the agents. **For PR scope, also list the other open PRs that change the same files:** diff --git a/tools/agents/config/skills/review-pr-comments-converge/SKILL.md b/tools/agents/config/skills/review-pr-comments-converge/SKILL.md index 0ff860a2..e0a6555b 100644 --- a/tools/agents/config/skills/review-pr-comments-converge/SKILL.md +++ b/tools/agents/config/skills/review-pr-comments-converge/SKILL.md @@ -1,6 +1,6 @@ --- name: review-pr-comments-converge -description: Fetch PR review comments, validate each against the actual code, auto-fix obvious issues, and escalate genuine design decisions. Leaves all changes in the working tree. Use when you want to action reviewer feedback autonomously. +description: Fetch PR review comments, validate each unanswered one against the actual code, auto-fix obvious issues, and escalate genuine design decisions. Leaves all changes in the working tree. Use when you want to action reviewer feedback autonomously. argument-hint: '' effort: high model: opus @@ -79,9 +79,36 @@ prose such as a review body names that author, on the same rule: `@login` for a `BOT_NAMES` name for a bot, `a deleted account` for a deleted one, and `UNKNOWN` wherever `thank` shows it. +Each review with a body, each inline thread and each conversation comment also shows +**`answered`**, judged from the PR as it stands at this fetch. The **`# Answerers:`** line under +`# Source:` names the accounts whose posts count as answers: the PR's author and the gh login +running the fetch. A deleted account's post never counts. A thread comment is timed from when it +was published, not when it was drafted in a pending review, and a post or edit in the same second +as an answer counts as newer than it. + +- `yes (...)` names the evidence that counted: + - `resolved by `: the thread was resolved by the one person, other than the answerers, who + commented in it, and nothing that person wrote was posted or edited at or after the latest + answerer's reply in it. Any other resolution, by a bot, a deleted account, someone else or an + answerer, counts for nothing: the thread is judged as if it were unresolved. + - `reply by at