diff --git a/assets/CONTEXT.md b/assets/CONTEXT.md index 3f5f03c7..e6028897 100644 --- a/assets/CONTEXT.md +++ b/assets/CONTEXT.md @@ -73,7 +73,7 @@ The PR body's `## Models` section records its size as `Size: M` (its quest's, or Keep pull request CI read-only (a read-only `GITHUB_TOKEN`, write credentials only in environments limited to protected branches): quest branches are pushed to the repository, so their workflows get its secrets. Flag a workflow that breaks this. -A PR that fixes a bug, or redoes work an earlier PR did badly, lists that PR under `## Caused by` as `- [owner/repo#N](url) - what it got wrong`, found by `git blame` on the lines the fix changes, or says in one line that no single PR caused it, such as an upstream change or a bug as old as the code. +A PR that fixes a bug, or redoes work an earlier PR did badly, lists that PR under `## Caused by` as `- [owner/repo#N](url) - what it got wrong`, found by `git blame` on the lines the fix changes or named in its quest's Plan, and confirmed in that PR's diff to introduce the defect, not merely touch the lines, defer the work, or keep older behavior, else traced further back with blame, or says in one line that no single PR caused it, such as an upstream change or a bug as old as the code. Review findings fixed in the same PR are not culprits. ## Quests diff --git a/quest/m0/caused-by-culprits.md b/quest/m0/caused-by-culprits.md deleted file mode 100644 index 5627f652..00000000 --- a/quest/m0/caused-by-culprits.md +++ /dev/null @@ -1,30 +0,0 @@ -# [S] Caused by names only the PR that shipped the defect - -## Goal - -A fix's `## Caused by` names the PR whose diff introduced the defect, not -one that only touched the same lines, deferred the work to a planned -follow-up, or kept behavior older than it, so the escapes `quest usage` -counts are defects. - -## Plan - -The 2026-11-11 [mistake audit](/quest/m0/mistake-audit.md) found 4 of 14 -moq-dev/moq culprit links named a PR that shipped no defect: -[moq-dev/moq#8294](https://github.com/moq-dev/moq/pull/8294) and -[moq-dev/moq#8440](https://github.com/moq-dev/moq/pull/8440) left the work -to a planned follow-up, -[moq-dev/moq#8362](https://github.com/moq-dev/moq/pull/8362) deferred it on -the maintainer's decision, and -[moq-dev/moq#8402](https://github.com/moq-dev/moq/pull/8402) kept an older -order. `quest context` says to find the culprit "by `git blame` on the -lines the fix changes", which finds the last PR to touch them. - -Agent's choices, for the implementer to revisit: - -- Reword that rule in `assets/CONTEXT.md` to confirm in the blamed PR's - diff that it introduced the defect, else follow blame further back or - say no single PR caused it. This is a prose rule because only judgment - can tell a defect from a deferral. `assets/CONTEXT.md` is at 9,933 of - its 10,000 characters, so the rewording must not grow it. -- Follow `quest guide prompting`. diff --git a/quest/m0/mistake-audit.md b/quest/m0/mistake-audit.md index a82ab787..b9ded9f5 100644 --- a/quest/m0/mistake-audit.md +++ b/quest/m0/mistake-audit.md @@ -136,8 +136,8 @@ messages 2026-10-26 to 11-11, classed by one sub-agent, approximate): - A shell pipeline under `pipefail` whose reader exits early, a race: 1 this week in moq-dev/moq.pro, its third fix there. - Named a PR that deferred the work, or kept older behavior, as a - culprit: 4 in moq-dev/moq, which - [Caused by culprits](/quest/m0/caused-by-culprits.md) takes. + culprit: 4 in moq-dev/moq; `quest context` now requires confirming + the culprit in the blamed PR's diff. - Typed mid-session messages, per 100, before 2026-11-09 (841) then after (131): stalls until nudged 6.5 then 4.6; proposals steered simpler 4.8 then 0; misread intent 1.9 then 3.1; reported instead of fixed 0.7 then