From 46fb33f7cb68a50cbe3390cc90fb67bcfc53bd3a Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Thu, 12 Nov 2026 09:13:31 -0800 Subject: [PATCH 1/3] ci: Nightly's TLA+ matrix drops the route config #8541 deleted Co-Authored-By: Claude Opus 5.5 --- .github/workflows/nightly.yml | 12 +++++------- sh/gh/nightly.test.py | 11 +++++++++++ 2 files changed, 16 insertions(+), 7 deletions(-) diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index 4e4bb2fc8b3..c277d0e4faa 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -427,21 +427,19 @@ jobs: strategy: fail-fast: false matrix: - # The largest models get a runner each, and the route model's three - # largest configs (about an hour each on 4 workers) one per config; the - # `route` and `rest` legs take every other config, so a new one is - # checked without editing this list. + # The largest models get a runner each, and the route model's two + # largest configs one per config; the `route` and `rest` legs take + # every other config, so a new one is checked without editing this + # list. sh/gh/nightly.test.py fails on a path that no longer exists. include: - name: resume paths: rs/moq-net/verify/resume - name: route triangle paths: rs/moq-net/verify/route/RouteHandoff.cfg - - name: route behind - paths: rs/moq-net/verify/route/BehindDear.cfg - name: route ring paths: rs/moq-net/verify/route/Ring.cfg - name: route - paths: "rs/moq-net/verify/route :!rs/moq-net/verify/route/RouteHandoff.cfg :!rs/moq-net/verify/route/BehindDear.cfg :!rs/moq-net/verify/route/Ring.cfg" + paths: "rs/moq-net/verify/route :!rs/moq-net/verify/route/RouteHandoff.cfg :!rs/moq-net/verify/route/Ring.cfg" - name: rest paths: ":!rs/moq-net/verify/resume :!rs/moq-net/verify/route" steps: diff --git a/sh/gh/nightly.test.py b/sh/gh/nightly.test.py index 2ea0709a19e..2161494179e 100644 --- a/sh/gh/nightly.test.py +++ b/sh/gh/nightly.test.py @@ -357,6 +357,17 @@ def test_dev_shell_jobs_trust_the_nix_cache(self): if "nix develop" in job: self.assertIn("uses: ./.github/actions/nix", job, job.splitlines()[0]) + def test_every_tla_leg_path_exists(self): + # A leg naming a deleted config checks nothing and fails Nightly; an + # exclusion naming one silently stops excluding. + workflow = (ROOT / ".github/workflows/nightly.yml").read_text() + job = re.search(r"^ tla:\n(.*?)^ \S", workflow, re.M | re.S) + self.assertIsNotNone(job) + paths = [p for line in re.findall(r"^ +paths: (.+)$", job[1], re.M) for p in line.strip("\"").split()] + self.assertTrue(paths) + missing = [p for p in paths if not (ROOT / p.removeprefix(":!")).exists()] + self.assertEqual(missing, [], "TLA+ matrix paths that no longer exist") + def test_benchmark_tests_stay_out_of_cargo_bench(self): workflow = (ROOT / ".github/workflows/nightly.yml").read_text() for group in RUST_TEST_GROUPS: From 512a96646f1d381670737a09daf61466b9a9ef9b Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Thu, 12 Nov 2026 10:06:18 -0800 Subject: [PATCH 2/3] test(net): mark EndedRelay.cfg's failover finding as open, so Nightly expects it Co-Authored-By: Claude Opus 5.5 --- rs/moq-net/verify/failover/EndedRelay.cfg | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/rs/moq-net/verify/failover/EndedRelay.cfg b/rs/moq-net/verify/failover/EndedRelay.cfg index 283268079b6..79c636f7345 100644 --- a/rs/moq-net/verify/failover/EndedRelay.cfg +++ b/rs/moq-net/verify/failover/EndedRelay.cfg @@ -1,6 +1,7 @@ +\* Open finding: NoSkipWhileHeld. A relay whose track ended cannot move a fetch +\* off a route that dies (see the verify-failover skill). \* FailoverChain.cfg with B also routing through A, so the route can move at -\* the middle hop. Fails on the open finding in the verify-failover skill: a -\* relay whose track ended cannot move a fetch off a route that dies. +\* the middle hop. CONSTANTS G = 2 F = 2 From 44f633833dbe8dfaa49bf8c6781370f425bce013 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Thu, 12 Nov 2026 10:48:58 -0800 Subject: [PATCH 3/3] ci: format the TLA+ path test Co-Authored-By: Claude Opus 5.5 --- sh/gh/nightly.test.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sh/gh/nightly.test.py b/sh/gh/nightly.test.py index 2161494179e..8caeab4f03c 100644 --- a/sh/gh/nightly.test.py +++ b/sh/gh/nightly.test.py @@ -363,7 +363,7 @@ def test_every_tla_leg_path_exists(self): workflow = (ROOT / ".github/workflows/nightly.yml").read_text() job = re.search(r"^ tla:\n(.*?)^ \S", workflow, re.M | re.S) self.assertIsNotNone(job) - paths = [p for line in re.findall(r"^ +paths: (.+)$", job[1], re.M) for p in line.strip("\"").split()] + paths = [p for line in re.findall(r"^ +paths: (.+)$", job[1], re.M) for p in line.strip('"').split()] self.assertTrue(paths) missing = [p for p in paths if not (ROOT / p.removeprefix(":!")).exists()] self.assertEqual(missing, [], "TLA+ matrix paths that no longer exist")