diff --git a/quest/m0/nightly/README.md b/quest/m0/nightly/README.md index 0e52ecac867..a7b30bfa623 100644 --- a/quest/m0/nightly/README.md +++ b/quest/m0/nightly/README.md @@ -51,4 +51,3 @@ near the paired threshold (re-check if one repeats), a one-off ## Required - [Nightly's macOS platform job passes](/quest/m0/nightly/macos.md) - `moq-audio`'s tests compile on macOS again and the websocket version test's timeout is fixed if it recurs -- [Nightly's Windows platform job passes](/quest/m0/nightly/windows.md) - `moq-vaapi` is gated to Linux and Windows-only unused items are fixed, so `platform.yml`'s Windows job builds and tests cleanly diff --git a/quest/m0/nightly/windows.md b/quest/m0/nightly/windows.md deleted file mode 100644 index 4661fd79d9c..00000000000 --- a/quest/m0/nightly/windows.md +++ /dev/null @@ -1,31 +0,0 @@ -# [S] Nightly's Windows platform job passes - -## Goal - -The `Windows` job of `platform.yml` passes on `main`, both as Nightly's -`platform / Windows` and on `workflow_dispatch` runs and release PRs. Every -Windows-only warning or Linux-only crate it trips on is fixed at its cause, -not silenced for the job. - -## Plan - -Planned 2026-11-09 (maintainer, from -[moq-dev/moq#8251](https://github.com/moq-dev/moq/pull/8251)'s follow-ups, -/quest-unblock). Known causes: - -- `moq-vaapi` is not gated to Linux under `--all`, so the Windows build tries - to compile it. -- `moq-relay`'s memory integration test leaves items unused on Windows, - which `build.warnings = deny` turns into errors. -- The 2026-11-09 dispatch on `quest/m2/video-codec-receive` - ([run](https://github.com/moq-dev/moq/actions/runs/42635646987)) failed - `just rs test -p moq-video --no-default-features --features render` on a - `dead_code` warning at `rs/moq-video/src/encode/backend/mod.rs:84`. Check - whether `main` has it too. - -Reproduce each on a `workflow_dispatch` of `platform.yml` for this branch -before and after the fix. Gate platform-specific crates and items with `cfg` -where they are defined, so a later Windows-only warning shows up as one new -error rather than a pile. - -Public API: none. Wire: none. diff --git a/rs/moq-video/src/encode/backend/mod.rs b/rs/moq-video/src/encode/backend/mod.rs index f5ab121bed8..b14de0839db 100644 --- a/rs/moq-video/src/encode/backend/mod.rs +++ b/rs/moq-video/src/encode/backend/mod.rs @@ -80,7 +80,15 @@ pub(crate) trait Backend { fn flush(&mut self) -> Result<(), Error>; /// Submit one frame and collect everything it readied. - #[cfg(test)] + #[cfg(all( + test, + any( + feature = "openh264", + apple, + all(target_os = "android", feature = "mediacodec"), + all(target_os = "linux", feature = "vaapi"), + ) + ))] fn encode_all(&mut self, frame: &Frame, cut: bool) -> Result, Error> { self.encode(frame, cut)?; self.receive_all()