diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 11bb45a214..2767a8e4c3 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -13,11 +13,6 @@ Lint/IncompatibleIoSelectWithFiberScheduler: - 'lib/mongo/socket/ssl.rb' - 'lib/mongo/socket/tcp.rb' -# Offense count: 2 -Lint/NextWithoutAccumulator: - Exclude: - - 'lib/mongo/operation/shared/result/aggregatable.rb' - # Offense count: 12 Lint/RescueException: Exclude: diff --git a/lib/mongo/operation/shared/result/aggregatable.rb b/lib/mongo/operation/shared/result/aggregatable.rb index 42432d74c9..4ab693fd45 100644 --- a/lib/mongo/operation/shared/result/aggregatable.rb +++ b/lib/mongo/operation/shared/result/aggregatable.rb @@ -36,7 +36,7 @@ def aggregate_write_errors(count) return unless @replies @replies.reduce(nil) do |errors, reply| - next unless (write_errors = reply.documents.first['writeErrors']) + next errors unless (write_errors = reply.documents.first['writeErrors']) wes = write_errors.collect do |we| we.merge!('index' => count + we['index']) @@ -59,11 +59,11 @@ def aggregate_write_concern_errors(count) return unless @replies @replies.each_with_index.reduce(nil) do |errors, (reply, _)| - next unless (write_concern_errors = reply.documents.first['writeConcernErrors']) + next errors unless (write_concern_errors = reply.documents.first['writeConcernErrors']) (errors || []) << write_concern_errors.reduce(nil) do |errs, wce| wce.merge!('index' => count + wce['index']) - (errs || []) << write_concern_error + (errs || []) << wce end end end