From c3d3d4ca573d40cf663590e59ff8054f8267a2e8 Mon Sep 17 00:00:00 2001 From: Charissa Miller <48832936+clemiller@users.noreply.github.com> Date: Mon, 6 Jul 2026 13:04:49 -0400 Subject: [PATCH 1/4] fix(ics-analytics): update the platforms listed for ics analytics to the correct values --- app/config/allowed-values.json | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/app/config/allowed-values.json b/app/config/allowed-values.json index 22bb412c..3649a9f3 100644 --- a/app/config/allowed-values.json +++ b/app/config/allowed-values.json @@ -27,17 +27,7 @@ }, { "domainName": "ics-attack", - "allowedValues": [ - "Field Controller/RTU/PLC/IED", - "Safety Instrumented System/Protection Relay", - "Control Server", - "Input/Output Server", - "Data Historian", - "Human-Machine Interface", - "Engineering Workstation", - "None", - "Windows" - ] + "allowedValues": ["Windows", "Linux", "Network", "Embedded", "IaaS", "SaaS", "None"] } ] } From 98c75d1788c4d3e14600041a25eb02e696055822 Mon Sep 17 00:00:00 2001 From: Jared Ondricek <90368810+jondricek@users.noreply.github.com> Date: Mon, 19 Oct 2026 13:21:24 -0500 Subject: [PATCH 2/4] fix: update allowed values for ICS analytics --- app/config/allowed-values.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/config/allowed-values.json b/app/config/allowed-values.json index 3649a9f3..d7552100 100644 --- a/app/config/allowed-values.json +++ b/app/config/allowed-values.json @@ -27,7 +27,7 @@ }, { "domainName": "ics-attack", - "allowedValues": ["Windows", "Linux", "Network", "Embedded", "IaaS", "SaaS", "None"] + "allowedValues": ["Windows", "Linux", "Network Devices", "Embedded", "None"] } ] } From 1865287c94efaf896582c6350cac2ab50f373564 Mon Sep 17 00:00:00 2001 From: Jared Ondricek Date: Tue, 20 Oct 2026 16:12:11 -0500 Subject: [PATCH 3/4] test(allowed-values): isolate option lifecycle from seed defaults --- app/tests/api/system-configuration/allowed-values.spec.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/app/tests/api/system-configuration/allowed-values.spec.js b/app/tests/api/system-configuration/allowed-values.spec.js index 9b82c720..47718bf2 100644 --- a/app/tests/api/system-configuration/allowed-values.spec.js +++ b/app/tests/api/system-configuration/allowed-values.spec.js @@ -225,6 +225,11 @@ describe('Runtime allowed values API', function () { }); it('adds, toggles and removes options for multiple object types without broadening other scopes', async function () { + // Start with the option absent, regardless of the bundled seed defaults. + const seededRule = await getRule(platformRule); + await api('put', ruleUrl(seededRule), { + values: seededRule.values.filter(({ value }) => value !== 'Network Devices'), + }); const initial = (await api('get', rules)).body; const rule = initial.find((item) => sameRule(item, platformRule)); const option = { From 51dc365785e33049c38ec7592cff401556e47724 Mon Sep 17 00:00:00 2001 From: Jared Ondricek Date: Wed, 21 Oct 2026 12:27:02 -0500 Subject: [PATCH 4/4] test(sync): restore next allowed-values test fixture Remove the sync-specific fixture adjustment from PR #518 as requested. Leave test repairs for next; the seeded Network Devices assertion is expected to fail until addressed there. --- app/tests/api/system-configuration/allowed-values.spec.js | 5 ----- 1 file changed, 5 deletions(-) diff --git a/app/tests/api/system-configuration/allowed-values.spec.js b/app/tests/api/system-configuration/allowed-values.spec.js index 47718bf2..9b82c720 100644 --- a/app/tests/api/system-configuration/allowed-values.spec.js +++ b/app/tests/api/system-configuration/allowed-values.spec.js @@ -225,11 +225,6 @@ describe('Runtime allowed values API', function () { }); it('adds, toggles and removes options for multiple object types without broadening other scopes', async function () { - // Start with the option absent, regardless of the bundled seed defaults. - const seededRule = await getRule(platformRule); - await api('put', ruleUrl(seededRule), { - values: seededRule.values.filter(({ value }) => value !== 'Network Devices'), - }); const initial = (await api('get', rules)).body; const rule = initial.find((item) => sameRule(item, platformRule)); const option = {