Skip to content

Commit f1a3263

Browse files
DefaultRyanCopilot
andcommitted
Guard generic parameter stack back() access
- add explicit checks before using generic_param_stack.back() when rendering GenericTypeIndex - throw detailed invalid_argument messages for missing generic context and out-of-range generic parameter indexes Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 61a69fb9-fb73-4bf5-b557-d60d7f503390
1 parent 634dc4a commit f1a3263

1 file changed

Lines changed: 12 additions & 1 deletion

File tree

‎cppwinrt/type_writers.h‎

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -516,7 +516,18 @@ namespace cppwinrt
516516
},
517517
[&](GenericTypeIndex var)
518518
{
519-
write(generic_param_stack.back()[var.index]);
519+
if (generic_param_stack.empty())
520+
{
521+
throw_invalid("Invalid generic type parameter index ", std::to_string(var.index), ": no generic parameter context is active");
522+
}
523+
524+
auto const& generic_params = generic_param_stack.back();
525+
if (var.index >= generic_params.size())
526+
{
527+
throw_invalid("Invalid generic type parameter index ", std::to_string(var.index), ": only ", std::to_string(generic_params.size()), " generic parameters are available");
528+
}
529+
530+
write(generic_params[var.index]);
520531
},
521532
[&](auto&& type)
522533
{

0 commit comments

Comments
 (0)