Repository navigation
Does a construction cache hit re-validate captured wildcard values, or only the exact-match parts? #2930
Replies: 1 comment
|
Hi Arne Rei (@mahirhir), hope you're doing well! Really nice question, and thanks for laying out the explanation side so clearly, it made the gap easy to follow. From my read of current main (I could easily be missing something, so please correct me), there is a downstream check, but it's opt in per agent rather than a type check on the captured text:
On schema validation: I couldn't find a Maintainers, is that intended, with agents expected to handle bad wildcard values themselves? Or would it make sense to run |
Uh oh!
There was an error while loading. Please reload this page.
I've been reading the explanation and construction pipeline. validateExplanation.ts's checkActionProperty throws if a parameter value in the explanation doesn't exactly match the value in the action, and validateSubPhraseText requires the sub-phrases to cover the whole request with no gaps. That machinery only runs while a construction is being built, though. At match time, constructionMatch.ts's matchParts and matchedValues in constructionValue.ts fill parameter values two ways: parse and transform for exact-match parts, and for plain wildcard parts the raw captured substring goes straight into the values with no type check. Is a wildcard-captured value expected to get validated somewhere downstream before the action runs, or is the construction match itself considered sufficient?
All reactions