fix: Make TestData value_for_all return its value when targeting is off (#490)

Author: keelerm84

lib/ldclient-rb/integrations/test_data/flag_builder.rb

@@ -181,7 +181,7 @@ def variation_for_all(variation)
         # @return [FlagBuilder] the builder
         #
         def value_for_all(value)
-          variations(value).variation_for_all(0)
+          variations(value).variation_for_all(0).off_variation(0)
         end
 
         #

spec/integrations/test_data_spec.rb

@@ -178,6 +178,16 @@ module Integrations
           expect(f[:fallthrough][:variation]).to be(0)
         end
 
+        it 'returns the value_for_all value whether targeting is on or off' do
+          f = TestData::FlagBuilder.new('flag').value_for_all('x').build(1)
+          expect(f[:variations]).to eq(['x'])
+          expect(f[:fallthrough]).to eq({ variation: 0 })
+          expect(f[:offVariation]).to eq(0)
+
+          off_flag = TestData::FlagBuilder.new('flag').value_for_all('x').on(false).build(1)
+          expect(off_flag[:offVariation]).to eq(0)
+        end
+
         it 'clears existing rules when setting variation for all users' do
           f = TestData::FlagBuilder.new('flag')
                           .if_match('name', 'ben')