Merge pull request #1879 from gooddata/rr/LX-3248-flag-hint

fix(gooddata-eval): name the builder skill flag the backend defines

Author: romrak

packages/gooddata-eval/src/gooddata_eval/core/agentic/document_skill.py

@@ -1017,7 +1017,7 @@ def _run_detail(run: DocumentRunResult) -> dict[str, Any]:
         elif not best.evaluation.skill_activated:
             skill_note = (
                 f" set_skills never activated {_BUILDER_SKILL}: either the copilot routed elsewhere, or the skill"
-                " is not registered. It registers only with enableGenAiDocumentBuilderSkill and the org's"
+                " is not registered. It registers only with enableGenAiReportBuilderSkill and the org's"
                 " enableBusinessBriefingReportsApp both on."
             )
         exc = DocumentSkillAssertionError(

packages/gooddata-eval/tests/test_agentic_document_skill.py

@@ -523,7 +523,7 @@ def test_a_failing_item_on_the_report_names_points_at_the_rename_not_the_flags(
         evaluate_agentic_document_skill("https://h", "tok", "ws", "Create a document", {}, max_iterations=1)
 
     assert "gen-ai still sends the Report names" in str(raised.value)
-    assert "enableGenAiDocumentBuilderSkill" not in str(raised.value)
+    assert "enableGenAiReportBuilderSkill" not in str(raised.value)
 
 
 def test_a_user_context_with_view_report_fails_before_any_request(monkeypatch: pytest.MonkeyPatch) -> None:
@@ -669,7 +669,7 @@ def test_a_failing_item_without_document_builder_points_at_the_flags(monkeypatch
     _install_client(monkeypatch, _ScriptedChatClient([turn]))
     with pytest.raises(
         DocumentSkillAssertionError,
-        match="enableGenAiDocumentBuilderSkill and the org.s enableBusinessBriefingReportsApp",
+        match="enableGenAiReportBuilderSkill and the org.s enableBusinessBriefingReportsApp",
     ):
         evaluate_agentic_document_skill("https://h", "tok", "ws", "Create a document", {}, max_iterations=1)