From 22944d0ec737a1d22a1dddb9417ba96c84b34b7b Mon Sep 17 00:00:00 2001 From: Jude Kwashie Date: Tue, 13 Oct 2026 12:49:00 +0000 Subject: [PATCH] fix(core): use valid-format placeholder options for demoProjectId apps --- .../firebase_core/firebase_core/lib/src/firebase.dart | 4 ++-- .../firebase_core/test/firebase_core_test.dart | 4 ++-- .../firebase_core/firebase_core_e2e_test.dart | 9 +++++++++ 3 files changed, 13 insertions(+), 4 deletions(-) diff --git a/packages/firebase_core/firebase_core/lib/src/firebase.dart b/packages/firebase_core/firebase_core/lib/src/firebase.dart index 3edce466264a..f010a2c384a2 100644 --- a/packages/firebase_core/firebase_core/lib/src/firebase.dart +++ b/packages/firebase_core/firebase_core/lib/src/firebase.dart @@ -69,9 +69,9 @@ class Firebase { // for backwards compatibility and simply override the user-provided // options. resolvedOptions = FirebaseOptions( - apiKey: '12345', + apiKey: 'ADemoProjectApiKey000000000000000000000', appId: '1:1:$platformString:1', - messagingSenderId: '', + messagingSenderId: '1', projectId: demoProjectId, ); // Now fall through to the normal initialization logic. diff --git a/packages/firebase_core/firebase_core/test/firebase_core_test.dart b/packages/firebase_core/firebase_core/test/firebase_core_test.dart index 4354f38c5824..fa4715e3b782 100755 --- a/packages/firebase_core/firebase_core/test/firebase_core_test.dart +++ b/packages/firebase_core/firebase_core/test/firebase_core_test.dart @@ -121,10 +121,10 @@ void main() { const String demoProjectId = 'demo-project-id'; const String expectedName = demoProjectId; const FirebaseOptions expectedOptions = FirebaseOptions( - apiKey: '12345', + apiKey: 'ADemoProjectApiKey000000000000000000000', // Flutter tests use android as the default platform. appId: '1:1:android:1', - messagingSenderId: '', + messagingSenderId: '1', projectId: demoProjectId, ); diff --git a/tests/integration_test/firebase_core/firebase_core_e2e_test.dart b/tests/integration_test/firebase_core/firebase_core_e2e_test.dart index 8204337cd553..a5d298741bde 100644 --- a/tests/integration_test/firebase_core/firebase_core_e2e_test.dart +++ b/tests/integration_test/firebase_core/firebase_core_e2e_test.dart @@ -82,5 +82,14 @@ void main() { await app.setAutomaticResourceManagementEnabled(false); } }); + + test('Firebase.initializeApp() with demoProjectId', () async { + const demoProjectId = 'demo-flutterfire-e2e'; + final app = await Firebase.initializeApp(demoProjectId: demoProjectId); + addTearDown(app.delete); + + expect(app.name, demoProjectId); + expect(app.options.projectId, demoProjectId); + }); }); }