|
| 1 | +use super::*; |
| 2 | + |
| 3 | +fn fixture(label: &str) -> (PathBuf, Arc<ModuleState>, PreloadModelConfig) { |
| 4 | + let (root, descriptor) = test_storage_descriptor(label); |
| 5 | + let store = Arc::new(SynapseStore::open(&descriptor).unwrap()); |
| 6 | + let profile = test_machine_profile(label); |
| 7 | + store.activate_profile(&profile, 1, 1000).unwrap(); |
| 8 | + let mut state = test_module_state(store, profile); |
| 9 | + Arc::get_mut(&mut state).unwrap().model_cache = Arc::new(ModelCache::new(root.join("cache"))); |
| 10 | + make_test_tokenizer(&root, 512); |
| 11 | + fs::write(root.join("config.json"), br#"{"model_type":"modernbert"}"#).unwrap(); |
| 12 | + let header = br#"{"embedding.weight":{"dtype":"F16","shape":[2],"data_offsets":[0,4]}}"#; |
| 13 | + let mut weights = (header.len() as u64).to_le_bytes().to_vec(); |
| 14 | + weights.extend_from_slice(header); |
| 15 | + weights.extend_from_slice(&[0; 4]); |
| 16 | + fs::write(root.join("model.safetensors"), weights).unwrap(); |
| 17 | + let preload = serde_json::from_value(json!({ |
| 18 | + "model_id": "legacy-gte-embed", "engine": "owned-metal", "task": "embed", |
| 19 | + "family": "gte-modernbert", "dtype": "f16", "pooling": "mean", |
| 20 | + "model_path": root.join("model.safetensors"), |
| 21 | + "tokenizer_path": root.join("tokenizer.json") |
| 22 | + })) |
| 23 | + .unwrap(); |
| 24 | + (root, state, preload) |
| 25 | +} |
| 26 | + |
| 27 | +#[test] |
| 28 | +fn readout_table_is_operation_specific() { |
| 29 | + for (family, task, expected) in [ |
| 30 | + ( |
| 31 | + OwnedFamily::GteModernBert, |
| 32 | + ModelTask::Embed, |
| 33 | + WorkerPooling::Cls, |
| 34 | + ), |
| 35 | + ( |
| 36 | + OwnedFamily::GteModernBert, |
| 37 | + ModelTask::Rerank, |
| 38 | + WorkerPooling::Mean, |
| 39 | + ), |
| 40 | + (OwnedFamily::Qwen3, ModelTask::Embed, WorkerPooling::Last), |
| 41 | + (OwnedFamily::Qwen3, ModelTask::Rerank, WorkerPooling::Last), |
| 42 | + ] { |
| 43 | + assert_eq!(owned_metal_readout_pooling(family, task), Some(expected)); |
| 44 | + } |
| 45 | +} |
| 46 | + |
| 47 | +#[tokio::test] |
| 48 | +async fn new_owned_metal_gte_embed_load_refuses_mean_and_omitted_pooling() { |
| 49 | + let (root, state, _) = fixture("metal-readout-load"); |
| 50 | + for pooling in [Some("mean"), None] { |
| 51 | + let mut params = json!({ |
| 52 | + "source": "file", "path": root, "engine": "owned-metal", |
| 53 | + "family": "gte-modernbert", "task": "embed", |
| 54 | + "model_id": "new-gte-embed", |
| 55 | + "files": {"model": "model.safetensors", "tokenizer": "tokenizer.json", "config": "config.json"}, |
| 56 | + "request_key": format!("readout-{pooling:?}") |
| 57 | + }); |
| 58 | + if let Some(pooling) = pooling { |
| 59 | + params["pooling"] = json!(pooling); |
| 60 | + } |
| 61 | + let accepted = response_result(model_load(state.clone(), params).await, "model.load"); |
| 62 | + let job_id = accepted["job_id"].as_str().expect("load job admitted"); |
| 63 | + let record = tokio::time::timeout(Duration::from_secs(10), async { |
| 64 | + loop { |
| 65 | + let record = state.store.get_job(job_id).unwrap().unwrap(); |
| 66 | + if record.state == JOB_STATE_FAILED_PERMANENT |
| 67 | + || record.state == JOB_STATE_FAILED_TRANSIENT |
| 68 | + || record.state == JOB_STATE_DONE |
| 69 | + { |
| 70 | + break record; |
| 71 | + } |
| 72 | + tokio::task::yield_now().await; |
| 73 | + } |
| 74 | + }) |
| 75 | + .await |
| 76 | + .expect("load job completed"); |
| 77 | + let error = record.error_json.unwrap_or(Value::Null); |
| 78 | + assert_eq!(error["code"], "invalid_request", "{error}"); |
| 79 | + assert_eq!( |
| 80 | + error["message"], |
| 81 | + "owned-metal gte-modernbert embedding computes cls; declare \"pooling\": \"cls\"" |
| 82 | + ); |
| 83 | + assert!(state.store.catalog_models().unwrap().is_empty()); |
| 84 | + assert!(model_slot_snapshot(&state.runtime, "new-gte-embed").is_none()); |
| 85 | + } |
| 86 | + drop(state); |
| 87 | + fs::remove_dir_all(root).unwrap(); |
| 88 | +} |
| 89 | + |
| 90 | +#[test] |
| 91 | +fn new_owned_metal_preload_refuses_mean_but_accepts_cls() { |
| 92 | + let (root, state, mut preload) = fixture("metal-readout-preload"); |
| 93 | + for pooling in [Some("mean"), None] { |
| 94 | + preload.pooling = pooling.map(str::to_string); |
| 95 | + let config = ModuleConfig { |
| 96 | + preload_models: vec![preload.clone()], |
| 97 | + ..ModuleConfig::default() |
| 98 | + }; |
| 99 | + let error = sync_and_load_catalog_models( |
| 100 | + &state.store, |
| 101 | + &config, |
| 102 | + &state.runtime.release_catalog, |
| 103 | + &state.model_cache, |
| 104 | + ) |
| 105 | + .unwrap_err(); |
| 106 | + assert!(error |
| 107 | + .to_string() |
| 108 | + .contains("computes cls; declare \"pooling\": \"cls\"")); |
| 109 | + assert!(state.store.catalog_models().unwrap().is_empty()); |
| 110 | + } |
| 111 | + preload.pooling = Some("cls".into()); |
| 112 | + let config = ModuleConfig { |
| 113 | + preload_models: vec![preload], |
| 114 | + ..ModuleConfig::default() |
| 115 | + }; |
| 116 | + let loaded = sync_and_load_catalog_models( |
| 117 | + &state.store, |
| 118 | + &config, |
| 119 | + &state.runtime.release_catalog, |
| 120 | + &state.model_cache, |
| 121 | + ) |
| 122 | + .unwrap(); |
| 123 | + assert_eq!(loaded.len(), 1); |
| 124 | + assert_eq!(loaded[0].pooling, "cls"); |
| 125 | + drop(state); |
| 126 | + fs::remove_dir_all(root).unwrap(); |
| 127 | +} |
| 128 | + |
| 129 | +#[test] |
| 130 | +fn persisted_owned_metal_mean_survives_startup_with_and_without_preload() { |
| 131 | + let (root, state, preload) = fixture("metal-readout-persisted"); |
| 132 | + // Capture the legacy declaration through the unchanged builder, before |
| 133 | + // simulating a restart with a row that already exists in the store. |
| 134 | + let legacy = build_preload_catalog_model( |
| 135 | + 0, |
| 136 | + preload.clone(), |
| 137 | + &state.runtime.inline, |
| 138 | + &state.runtime.jobs, |
| 139 | + ) |
| 140 | + .unwrap(); |
| 141 | + state.store.upsert_model(&legacy, 1).unwrap(); |
| 142 | + let legacy_bytes = serde_json::to_vec(&legacy).unwrap(); |
| 143 | + for preloads in [Vec::new(), vec![preload]] { |
| 144 | + let config = ModuleConfig { |
| 145 | + preload_models: preloads, |
| 146 | + ..ModuleConfig::default() |
| 147 | + }; |
| 148 | + let loaded = sync_and_load_catalog_models( |
| 149 | + &state.store, |
| 150 | + &config, |
| 151 | + &state.runtime.release_catalog, |
| 152 | + &state.model_cache, |
| 153 | + ) |
| 154 | + .unwrap(); |
| 155 | + assert_eq!(loaded.len(), 1); |
| 156 | + assert_eq!(loaded[0].pooling, "mean"); |
| 157 | + assert_eq!(loaded[0].fingerprint, legacy.fingerprint); |
| 158 | + assert_eq!(serde_json::to_vec(&loaded[0]).unwrap(), legacy_bytes); |
| 159 | + assert_eq!(state.store.catalog_models().unwrap(), vec![legacy.clone()]); |
| 160 | + let runtime = RuntimeState::from_catalog(config, loaded).unwrap(); |
| 161 | + let slot = model_slot_snapshot(&runtime, &legacy.model_id).unwrap(); |
| 162 | + assert_eq!(slot.spec, legacy); |
| 163 | + } |
| 164 | + drop(state); |
| 165 | + fs::remove_dir_all(root).unwrap(); |
| 166 | +} |
0 commit comments