From e45b863ac3a0360e9718dcc33afabf9144266faa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kr=C3=A6n=20Hansen?= Date: Sun, 11 Oct 2026 23:34:51 +0200 Subject: [PATCH] cmake-rn: honor CODE_SIGNING_ALLOWED for framework targets #430 only passed CODE_SIGNING_ALLOWED to the `cmake --build` used for plain dynamic libraries; the `xcodebuild archive`/`install` calls for CMake FRAMEWORK targets kept signing, leaving a _CodeSignature directory in each. Co-Authored-By: Claude Opus 5.5 (1M context) --- .changeset/framework-code-signing.md | 8 ++++++++ packages/cmake-rn/src/platforms/apple.ts | 1 + 2 files changed, 9 insertions(+) create mode 100644 .changeset/framework-code-signing.md diff --git a/.changeset/framework-code-signing.md b/.changeset/framework-code-signing.md new file mode 100644 index 00000000..4444d2d8 --- /dev/null +++ b/.changeset/framework-code-signing.md @@ -0,0 +1,8 @@ +--- +"cmake-rn": patch +--- + +Apply `--code-signing-allowed` to CMake framework targets too. It was only +passed when building plain dynamic libraries, so framework targets built +through `xcodebuild archive`/`install` were always signed, leaving a +`_CodeSignature` directory in each framework. diff --git a/packages/cmake-rn/src/platforms/apple.ts b/packages/cmake-rn/src/platforms/apple.ts index 2811bcbb..82740793 100644 --- a/packages/cmake-rn/src/platforms/apple.ts +++ b/packages/cmake-rn/src/platforms/apple.ts @@ -424,6 +424,7 @@ export const platform: Platform = { configuration, "-destination", DESTINATION_BY_TRIPLET[triplet], + `CODE_SIGNING_ALLOWED=${codeSigningAllowed ? "YES" : "NO"}`, ], buildPath, );