Skip to content

Commit 8d3dcfa

Browse files
committed
chore: drop comments from fork pin and tests
1 parent d39a4af commit 8d3dcfa

3 files changed

Lines changed: 0 additions & 11 deletions

File tree

‎awslambdaric/lambda_multi_concurrent_utils.py‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@ def run_concurrent(
6767
):
6868
cls._emit_worker_pool_event(max_concurrency)
6969

70-
# Not the interpreter default: fork on 3.13, forkserver on 3.14+.
7170
ctx = multiprocessing.get_context("fork")
7271
processes = []
7372
for _ in range(max_concurrency):

‎tests/test_concurrency.py‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -57,14 +57,6 @@ def fake_bootstrap_run(handler, lambda_runtime_client):
5757
self.assertEqual(fail_counter.value, 2)
5858

5959
def test_workers_are_forked_children_regardless_of_default_start_method(self):
60-
"""The runner must not inherit the interpreter default start method.
61-
62-
Force the default to "forkserver" (what 3.14+ picks) and check that
63-
workers are still direct children of this process, that the parent
64-
forked while single-threaded, and that a module imported in the parent
65-
before the fork is already present in each worker (fork semantics, not
66-
a fresh interpreter).
67-
"""
6860
previous = multiprocessing.get_start_method(allow_none=True)
6961
multiprocessing.set_start_method("forkserver", force=True)
7062
try:

‎tests/test_multi_concurrent_runner.py‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,6 @@ def test_run_concurrent_spawns_and_joins(self, mock_get_context, mock_emit):
8383
@patch.object(MultiConcurrentRunner, "_emit_worker_pool_event")
8484
@patch("multiprocessing.get_context")
8585
def test_run_concurrent_pins_fork_start_method(self, mock_get_context, mock_emit):
86-
"""Workers come from an explicit "fork" context, never from the
87-
interpreter default (fork on 3.13, forkserver on 3.14+)."""
8886
mock_ctx = MagicMock()
8987
mock_get_context.return_value = mock_ctx
9088

0 commit comments

Comments
 (0)