Fix the lint

Author: jamesdaniels

eslint.config.js

@@ -96,6 +96,21 @@ module.exports = [
           "newlines-between": "never"
         },
       ],
+      '@angular-eslint/prefer-inject': 'off',
+      '@typescript-eslint/no-empty-object-type': 'off',
+      'import/named': 'off',
+      "@typescript-eslint/no-unused-vars": [
+        "error",
+        {
+          "argsIgnorePattern": "^_",
+          "varsIgnorePattern": "^_",
+          "caughtErrorsIgnorePattern": "^_",
+          "ignoreRestSiblings": true
+        }
+      ],
+      "@typescript-eslint/prefer-promise-reject-errors": "off",
+      "@typescript-eslint/no-require-imports": "off",
+      "@typescript-eslint/ban-ts-comment": "warn",
     },
   },
   {

package.json

@@ -20,7 +20,7 @@
     "test:all": "npm run test:node-esm && npm run test:chrome-headless && npm run test:typings && npm run test:build",
     "build": "rimraf dist && tspc -p tsconfig.build.json && node --trace-warnings ./tools/build.js && npm pack ./dist/packages-dist",
     "buildd": "tsc -p tsconfig.build.json && node --trace-warnings ./tools/build.js && npm pack ./dist/packages-dist",
-    "build:jasmine": "npx tsc -p tsconfig.jasmine.json --module es2015 && cp ./dist/out-tsc/jasmine/tools/jasmine.js ./dist/out-tsc/jasmine/tools/jasmine.mjs && npx tsc -p tsconfig.jasmine.json && cp ./dist/packages-dist/schematics/versions.json ./dist/out-tsc/jasmine/schematics",
+    "build:jasmine": "npx tsc -p tsconfig.jasmine.json --module es2015 && cp ./dist/out-tsc/jasmine/tools/jasmine.js ./dist/out-tsc/jasmine/tools/jasmine.mjs && npx tsc -p tsconfig.jasmine.json && cp ./dist/packages-dist/schematics/versions.json ./dist/out-tsc/jasmine/src/schematics",
     "changelog": "conventional-changelog -p angular -i CHANGELOG.md -s -r 1"
   },
   "husky": {

src/app/app.module.ts

@@ -63,7 +63,6 @@ export function firebaseAppFactory(fn: (injector: Injector) => IFirebaseApp) {
   ]
 })
 export class FirebaseAppModule {
-  // eslint-disable-next-line @typescript-eslint/ban-types
   constructor(@Inject(PLATFORM_ID) platformId: object) {
     registerVersion('angularfire', VERSION.full, 'core');
     registerVersion('angularfire', VERSION.full, 'app');

src/compat/analytics/analytics.ts

@@ -49,7 +49,7 @@ export class AngularFireAnalytics {
     @Optional() @Inject(APP_NAME) providedAppName: string | null,
     @Optional() @Inject(DEBUG_MODE) debugModeEnabled: boolean | null,
     @Optional() @Inject(CONFIG) providedConfig: Config | null,
-    // eslint-disable-next-line @typescript-eslint/ban-types
+
     @Inject(PLATFORM_ID) platformId: object,
     zone: NgZone,
     schedulers: ɵAngularFireSchedulers,

src/compat/analytics/user-tracking.service.ts

@@ -15,7 +15,7 @@ export class UserTrackingService implements OnDestroy {
   // TODO a user properties injector
   constructor(
     analytics: AngularFireAnalytics,
-    // eslint-disable-next-line @typescript-eslint/ban-types
+
     @Inject(PLATFORM_ID) platformId: object,
     auth: AngularFireAuth,
     zone: NgZone,

src/compat/angularfire2.spec.ts

@@ -1,15 +1,12 @@
-import { CompilerFactory, DoBootstrap, NgModule, PlatformRef } from '@angular/core';
 import { TestBed } from '@angular/core/testing';
 import { ɵZoneScheduler } from '@angular/fire';
 import { AngularFireModule, FirebaseApp } from '@angular/fire/compat';
-import { BrowserModule } from '@angular/platform-browser';
 import { TestScheduler } from 'rxjs/testing';
 import { COMMON_CONFIG } from '../../src/test-config';
 import { rando } from '../../src/utils';
 
 describe('angularfire', () => {
   let app: FirebaseApp;
-  let defaultPlatform: PlatformRef;
   let appName: string;
 
   beforeEach(() => {
@@ -21,7 +18,6 @@ describe('angularfire', () => {
     });
 
     app = TestBed.inject(FirebaseApp);
-    defaultPlatform = TestBed.inject(PlatformRef);
   });
 
   describe('ZoneScheduler', () => {

src/compat/auth/auth.ts

@@ -87,7 +87,7 @@ export class AngularFireAuth {
   constructor(
     @Inject(FIREBASE_OPTIONS) options: FirebaseOptions,
     @Optional() @Inject(FIREBASE_APP_NAME) name: string|null|undefined,
-    // eslint-disable-next-line @typescript-eslint/ban-types
+
     @Inject(PLATFORM_ID) platformId: object,
     zone: NgZone,
     schedulers: ɵAngularFireSchedulers,

src/compat/database/database.ts

@@ -37,7 +37,7 @@ export class AngularFireDatabase {
     @Inject(FIREBASE_OPTIONS) options: FirebaseOptions,
     @Optional() @Inject(FIREBASE_APP_NAME) name: string | null | undefined,
     @Optional() @Inject(URL) databaseURL: string | null,
-    // eslint-disable-next-line @typescript-eslint/ban-types
+
     @Inject(PLATFORM_ID) platformId: object,
     zone: NgZone,
     public schedulers: ɵAngularFireSchedulers,

src/compat/database/list/create-reference.ts

@@ -32,7 +32,7 @@ export function createListReference<T= any>(query: DatabaseQuery, afDatabase: An
       const snapshotChanges$ = snapshotChanges<T>(query, events, outsideAngularScheduler);
       return snapshotChanges$.pipe(
         map(actions => actions.map(a => {
-          if (options && options.idField) {
+          if (options?.idField) {
             return {
               ...a.payload.val() as T,
               ...{

src/compat/firebase.app.module.ts

@@ -15,7 +15,7 @@ export function ɵfirebaseAppFactory(options: FirebaseOptions, zone: NgZone, nam
   const config = typeof nameOrConfig === 'object' && nameOrConfig || {};
   config.name = config.name || name;
   // Added any due to some inconsistency between @firebase/app and firebase types
-  const existingApp = firebase.apps.filter(app => app && app.name === config.name)[0];
+  const existingApp = firebase.apps.find(app => app && app.name === config.name);
   // We support FirebaseConfig, initializeApp's public type only accepts string; need to cast as any
   // Could be solved with https://github.com/firebase/firebase-js-sdk/pull/1206
   const app = (existingApp || zone.runOutsideAngular(() => firebase.initializeApp(options, config as any)));
@@ -24,11 +24,11 @@ export function ɵfirebaseAppFactory(options: FirebaseOptions, zone: NgZone, nam
       const hmr = !!(module as any).hot;
       log('error', `${app.name} Firebase App already initialized with different options${hmr ? ', you may need to reload as Firebase is not HMR aware.' : '.'}`);
     }
-  } catch (e) { /* empty */ }
+  } catch (_) { /* empty */ }
   return new FirebaseApp(app);
 }
 
-const log = (level: 'log'|'error'|'info'|'warn', ...args: any) => {
+const log = (level: 'log' | 'error' | 'info' | 'warn', ...args: any) => {
   if (isDevMode() && typeof console !== 'undefined') {
     // eslint-disable-next-line no-console
     console[level](...args);
@@ -53,13 +53,12 @@ export class AngularFireModule {
     return {
       ngModule: AngularFireModule,
       providers: [
-        {provide: FIREBASE_OPTIONS, useValue: options},
-        {provide: FIREBASE_APP_NAME, useValue: nameOrConfig}
+        { provide: FIREBASE_OPTIONS, useValue: options },
+        { provide: FIREBASE_APP_NAME, useValue: nameOrConfig }
       ]
     };
   }
 
-  // eslint-disable-next-line @typescript-eslint/ban-types
   constructor(@Inject(PLATFORM_ID) platformId: object) {
     firebase.registerVersion('angularfire', VERSION.full, 'core');
     firebase.registerVersion('angularfire', VERSION.full, 'app-compat');