Skip to content

Commit 1eb4449

Browse files
bokelleyclaude
andauthored
docs(reporting-storage): say adcp 10.0.0b4 and b5 still install beside storage 0.2.0b0 (#1840)
The contract check that refuses a storage package of another contract ships in adcp 10.0.0b7. adcp 10.0.0b4 and 10.0.0b5 predate it and still resolve beside adcp-reporting-storage 0.2.0b0, and that pair fails every reporting turn with `column "offering_id" does not exist`. The migration guide, the storage README and MIGRATION_v9_to_v10.md said the pair is refused at startup from 0.2.0b1. Name the adcp release that refuses it, say which releases don't, and point to adcp>=10.0.0b7. The README also said a forced pair "refuses at startup". With adcp 10.0.0b3 or earlier it fails at import instead, before the check runs. Refs #1837 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
1 parent 65d0c54 commit 1eb4449

3 files changed

Lines changed: 24 additions & 10 deletions

File tree

‎MIGRATION_v9_to_v10.md‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,12 @@ adcp 10.0.0b0–b3 are 1):
6666
- `adcp-reporting-storage` 0.2.0b1 requires `adcp>=10.0.0b4,<11`; the
6767
0.2.0b0 / 0.1.0b4 releases do not work with 10.0.0b4 or later
6868
([#1763](https://github.com/adcontextprotocol/adcp-client-python/issues/1763)).
69-
- Startup (`ReliableReportingService`, `postgres_storage`) refuses a pair whose
70-
contracts differ with `REPORTING_SCHEMA_BEHIND`, naming both versions and
71-
the release to install.
69+
- From adcp 10.0.0b7, startup (`ReliableReportingService`, `postgres_storage`)
70+
refuses a pair whose contracts differ with `REPORTING_SCHEMA_BEHIND`, naming
71+
both versions and the release to install. adcp 10.0.0b4 and 10.0.0b5 have no
72+
such check and still install beside 0.2.0b0, which then fails every reporting
73+
turn, so install `adcp>=10.0.0b7`
74+
([#1837](https://github.com/adcontextprotocol/adcp-client-python/issues/1837)).
7275
- An existing SDK 9 ledger is upgraded in place by `create_schema()` or
7376
`python -m adcp migrate`: `offering_id` is added with `''` for every
7477
existing account-level generation, obligation and status, and the applied

‎docs/reporting-ledger-migration.md‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -288,9 +288,12 @@ adcp 10.0.0b4 widened the configuration generation key with `offering_id`
288288
(AdCP 3.3 reporting subscriptions) and reads it from `reporting_configurations`,
289289
`reporting_obligations` and `reporting_consumer_statuses`. The storage releases
290290
before 0.2.0b1 do not create the column, so that pair fails every reporting
291-
turn with `column "offering_id" does not exist`. From 0.2.0b1 the pair is
292-
refused at startup instead (storage contract 1 versus 2; see
293-
`packages/adcp-reporting-storage/README.md`), and both schema entry points
291+
turn with `column "offering_id" does not exist`. adcp 10.0.0b7 and later
292+
refuse that pair at startup instead (storage contract 1 versus 2; see
293+
`packages/adcp-reporting-storage/README.md`). adcp 10.0.0b4 and 10.0.0b5
294+
predate the check and still install beside 0.2.0b0, so that pair fails every
295+
turn: install `adcp>=10.0.0b7` with `adcp-reporting-storage>=0.2.0b1`
296+
(10.0.0b6 was not published). From 0.2.0b1, both schema entry points
294297
upgrade an existing ledger in place:
295298

296299
- `PgReportingLedgerStore.create_schema()`, which `ReliableReportingService`

‎packages/adcp-reporting-storage/README.md‎

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,14 +58,22 @@ the **storage contract**, numbered on both sides
5858
(`adcp_reporting_storage.STORAGE_CONTRACT`,
5959
`adcp.reporting.ledger.storage_contract.REPORTING_STORAGE_CONTRACT`) and bumped
6060
together whenever the shared layout changes. The dependency floor is the first
61-
`adcp` release of the contract this package implements, so an incompatible pair
62-
does not resolve; if one is forced, building a PostgreSQL store refuses at
63-
startup, naming both versions and the release to install.
61+
`adcp` release of the contract this package implements, so this release
62+
cannot be installed beside an older `adcp`. Forcing it anyway fails at import.
63+
From adcp 10.0.0b7, building a PostgreSQL store also refuses a package of another
64+
contract at startup (`REPORTING_SCHEMA_BEHIND`), naming both versions and the
65+
release to install.
66+
67+
That check is in `adcp`, so it cannot cover releases that predate it:
68+
`adcp` 10.0.0b4 and 10.0.0b5 still resolve beside 0.2.0b0 and fail every
69+
reporting turn with `column "offering_id" does not exist`
70+
([#1763](https://github.com/adcontextprotocol/adcp-client-python/issues/1763)).
71+
Install `adcp>=10.0.0b7` with this release.
6472

6573
| adcp-reporting-storage | storage contract | adcp |
6674
|---|---|---|
6775
| 0.1.0b4 (SDK 9 line) | 1 | `>=9.0.0,<10` |
68-
| 0.2.0b0 | 1 | `>=9.0.0,<11` (**do not pair with 10.0.0b4+**, [#1763](https://github.com/adcontextprotocol/adcp-client-python/issues/1763)) |
76+
| 0.2.0b0 | 1 | `>=9.0.0,<11` (**do not pair with 10.0.0b4+**: 10.0.0b4 and b5 install beside it and fail, b7+ refuse it, [#1763](https://github.com/adcontextprotocol/adcp-client-python/issues/1763)) |
6977
| 0.2.0b1+ | 2 | `>=10.0.0b4,<11` |
7078

7179
`adcp` never imports this package; a test in the main repository enforces that.

0 commit comments

Comments
 (0)