From fdaee299168ab302efa81b4537de2aa9df8ba937 Mon Sep 17 00:00:00 2001
From: Darcy Quesnel <dlq@Bernadette.local>
Date: Tue, 20 Oct 2026 14:45:22 -0400
Subject: [PATCH] Localize upload dialog buttons without text-based selectors

---
 .../app/views/userfiles/_dialogs.html.erb     |  2 ++
 BrainPortal/public/javascripts/userfiles.js   | 29 ++++++++++++-------
 2 files changed, 20 insertions(+), 11 deletions(-)

diff --git a/BrainPortal/app/views/userfiles/_dialogs.html.erb b/BrainPortal/app/views/userfiles/_dialogs.html.erb
index 56e7ed10b..0c2ef2c72 100644
--- a/BrainPortal/app/views/userfiles/_dialogs.html.erb
+++ b/BrainPortal/app/views/userfiles/_dialogs.html.erb
@@ -31,6 +31,8 @@
 <div id="upload-dialog"
   class="dlg-dialog"
   title="<%= t('.titles.upload_sf') %>"
+  data-cancel-label="<%= t('cancel') %>"
+  data-upload-label="<%= t('userfiles.common.upload') %>"
   data-max-upload-size="<%= RemoteResource.current_resource.meta[:upload_size_limit].to_i.megabytes %>"
   data-type-detect-url="<%= detect_file_type_userfiles_path %>"
 >
diff --git a/BrainPortal/public/javascripts/userfiles.js b/BrainPortal/public/javascripts/userfiles.js
index 9ef0ce001..d434e6eaa 100644
--- a/BrainPortal/public/javascripts/userfiles.js
+++ b/BrainPortal/public/javascripts/userfiles.js
@@ -743,24 +743,31 @@ $(function() {
       var upload_button = undefined;
 
       $('#upload-dialog')
-        .dialog('option', 'buttons', {
-          'Cancel': function (event) {
-            $(this).trigger('close.uf');
+        .dialog('option', 'buttons', [
+          {
+            text: $('#upload-dialog').data('cancel-label'),
+            click: function (event) {
+              $(this).trigger('close.uf');
+            }
           },
-          'Upload': function (event) {
-            var dialog = $(this);
-
-            dialog.trigger('close.uf');
-            userfiles.upload(dialog.children('form')[0])
-              .then(userfiles.refresh);
+          {
+            text: $('#upload-dialog').data('upload-label'),
+            'class': 'upload-submit',
+            click: function (event) {
+              var dialog = $(this);
+
+              dialog.trigger('close.uf');
+              userfiles.upload(dialog.children('form')[0])
+                .then(userfiles.refresh);
+            }
           }
-        })
+        ])
         .unbind('open.uf.up-open')
         .bind(  'open.uf.up-open', function () {
           if (!upload_button)
             upload_button = $('#upload-dialog')
               .parent()
-              .find(':button:contains("Upload")');
+              .find('button.upload-submit');
 
           upload_button
             .toggleClass('ui-state-disabled', true)