From 140f766012a3803fdfaf9be02fafc9e0fcaa79ba Mon Sep 17 00:00:00 2001 From: Ishkirat-Singh Date: Wed, 11 Nov 2026 19:24:28 +0530 Subject: [PATCH] fix: keep frozenset and deque values when cleaning event properties clean() turned set, list and tuple values into lists but sent frozenset and deque values as None, so those properties were silently lost. --- .sampo/changesets/frozen-deque-clean.md | 5 +++++ posthog/test/test_utils.py | 11 +++++++++++ posthog/utils.py | 4 ++-- 3 files changed, 18 insertions(+), 2 deletions(-) create mode 100644 .sampo/changesets/frozen-deque-clean.md diff --git a/.sampo/changesets/frozen-deque-clean.md b/.sampo/changesets/frozen-deque-clean.md new file mode 100644 index 000000000..086791a13 --- /dev/null +++ b/.sampo/changesets/frozen-deque-clean.md @@ -0,0 +1,5 @@ +--- +pypi/posthog: patch +--- + +Keep `frozenset` and `deque` property values when cleaning events instead of replacing them with `None`. diff --git a/posthog/test/test_utils.py b/posthog/test/test_utils.py index e655c8cd5..c8d5e5a1b 100644 --- a/posthog/test/test_utils.py +++ b/posthog/test/test_utils.py @@ -3,6 +3,7 @@ import sys import time import unittest +from collections import deque from contextlib import ExitStack from unittest import mock from dataclasses import dataclass @@ -315,6 +316,16 @@ def test_clean_containers_and_invalid_dict_values(self): "12345678-1234-5678-1234-567812345678", ] + assert utils.clean( + { + "frozenset": frozenset([Decimal("1.5")]), + "deque": deque([UUID("12345678123456781234567812345678")]), + } + ) == { + "frozenset": [1.5], + "deque": ["12345678-1234-5678-1234-567812345678"], + } + bad_value = object() def clean_or_raise(value): diff --git a/posthog/utils.py b/posthog/utils.py index 24e48a781..1f36416a8 100644 --- a/posthog/utils.py +++ b/posthog/utils.py @@ -4,7 +4,7 @@ import re import threading import time -from collections import defaultdict +from collections import defaultdict, deque from dataclasses import asdict, is_dataclass from datetime import date, datetime, timezone, timedelta from decimal import Decimal @@ -89,7 +89,7 @@ def clean(item): return str(item) if isinstance(item, (str, bool, numbers.Number, datetime, date, type(None))): return item - if isinstance(item, (set, list, tuple)): + if isinstance(item, (set, frozenset, list, tuple, deque)): return _clean_list(item) item = _clean_pydantic_model(item)