From dbfb25f3d620e065a2d766106ac0d5e53425d6fe Mon Sep 17 00:00:00 2001 From: Shy Alter Date: Wed, 4 Nov 2026 07:19:07 +0100 Subject: [PATCH 1/3] fix(flags): respect feature enrollment in local evaluation A flag with early access feature enrollment now uses the $feature_enrollment/ person property when it is passed, like the flags service. Without it, local evaluation is inconclusive (missing_context) and falls back to /flags, instead of returning a certain False for enrolled people. Co-Authored-By: Claude Opus 5.5 Generated-By: PostHog Desktop Task-Id: fecca688-37ac-44b6-a1b5-27e11cb0749b --- .../local-eval-feature-enrollment.md | 5 +++ posthog/feature_flags.py | 11 +++++++ posthog/test/test_feature_flags.py | 32 +++++++++++++++++++ 3 files changed, 48 insertions(+) create mode 100644 .sampo/changesets/local-eval-feature-enrollment.md diff --git a/.sampo/changesets/local-eval-feature-enrollment.md b/.sampo/changesets/local-eval-feature-enrollment.md new file mode 100644 index 000000000..9c9f98fe6 --- /dev/null +++ b/.sampo/changesets/local-eval-feature-enrollment.md @@ -0,0 +1,5 @@ +--- +pypi/posthog: patch +--- + +Local evaluation now respects early access feature enrollment. A flag with feature enrollment uses the `$feature_enrollment/` person property when you pass it, and otherwise falls back to the flags service. Before, it returned `False` for enrolled people who matched no release condition, while the flags service returned `True`. diff --git a/posthog/feature_flags.py b/posthog/feature_flags.py index cfe847fbb..e882762e5 100644 --- a/posthog/feature_flags.py +++ b/posthog/feature_flags.py @@ -492,6 +492,17 @@ def match_feature_flag_properties( flag_filters = flag.get("filters") or {} + if flag_filters.get("feature_enrollment"): + enrollment_key = f"$feature_enrollment/{flag.get('key')}" + if enrollment_key not in properties: + raise InconclusiveMatchError( + f"Flag has feature enrollment and '{enrollment_key}' was not passed", + reason=UnresolvedFlagReason.MISSING_CONTEXT, + ) + return ( + properties[enrollment_key] is True or properties[enrollment_key] == "true" + ) + # Holdouts are evaluated before release conditions, so a held-out value is excluded # from the flag's targeting entirely rather than being bucketed into a variant. holdout_variant = _get_holdout_variant(flag, bucketing_value) diff --git a/posthog/test/test_feature_flags.py b/posthog/test/test_feature_flags.py index eb89117b1..d273e59b2 100644 --- a/posthog/test/test_feature_flags.py +++ b/posthog/test/test_feature_flags.py @@ -1192,6 +1192,38 @@ def test_experience_continuity_flag_not_evaluated_locally(self, patch_flags): ) self.assertEqual(patch_flags.call_count, 1) + @parameterized.expand( + [ + ("enrollment not passed", {}, 0, "flags-fallback-value", 1), + ("enrolled", {"$feature_enrollment/beta-feature": "true"}, 0, True, 0), + ("opted out", {"$feature_enrollment/beta-feature": False}, 100, False, 0), + ] + ) + def test_feature_enrollment_flag( + self, _name, person_properties, rollout, expected, flags_calls + ): + client = Client(FAKE_TEST_API_KEY, secret_key="test") + client.feature_flags = [ + { + "id": 1, + "key": "beta-feature", + "active": True, + "filters": { + "groups": [{"properties": [], "rollout_percentage": rollout}], + "feature_enrollment": True, + }, + } + ] + with mock.patch("posthog.client.flags") as patch_flags: + patch_flags.return_value = { + "featureFlags": {"beta-feature": "flags-fallback-value"} + } + value = client.get_feature_flag( + "beta-feature", "distinct_id", person_properties=person_properties + ) + + self.assertEqual((value, patch_flags.call_count), (expected, flags_calls)) + @mock.patch.object(Client, "capture") @mock.patch("posthog.client.flags") def test_get_all_flags_with_fallback(self, patch_flags, patch_capture): From 68d53b56def8976196aff00c747908f2577cb546 Mon Sep 17 00:00:00 2001 From: Shy Alter Date: Wed, 4 Nov 2026 07:25:37 +0100 Subject: [PATCH 2/3] fix(flags): match the flags service enrollment values exactly Check enrollment only when feature_enrollment is boolean true, and treat only true or "true" as enrolled, like the flags service. A value such as 1 now reads as opted out instead of enrolled. Co-Authored-By: Claude Opus 5.5 Generated-By: PostHog Desktop Task-Id: fecca688-37ac-44b6-a1b5-27e11cb0749b --- posthog/feature_flags.py | 7 +++---- posthog/test/test_feature_flags.py | 7 +++++++ 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/posthog/feature_flags.py b/posthog/feature_flags.py index e882762e5..a2790b46a 100644 --- a/posthog/feature_flags.py +++ b/posthog/feature_flags.py @@ -492,16 +492,15 @@ def match_feature_flag_properties( flag_filters = flag.get("filters") or {} - if flag_filters.get("feature_enrollment"): + if flag_filters.get("feature_enrollment") is True: enrollment_key = f"$feature_enrollment/{flag.get('key')}" if enrollment_key not in properties: raise InconclusiveMatchError( f"Flag has feature enrollment and '{enrollment_key}' was not passed", reason=UnresolvedFlagReason.MISSING_CONTEXT, ) - return ( - properties[enrollment_key] is True or properties[enrollment_key] == "true" - ) + enrollment = properties[enrollment_key] + return enrollment is True or enrollment == "true" # Holdouts are evaluated before release conditions, so a held-out value is excluded # from the flag's targeting entirely rather than being bucketed into a variant. diff --git a/posthog/test/test_feature_flags.py b/posthog/test/test_feature_flags.py index d273e59b2..6b64f5889 100644 --- a/posthog/test/test_feature_flags.py +++ b/posthog/test/test_feature_flags.py @@ -1197,6 +1197,13 @@ def test_experience_continuity_flag_not_evaluated_locally(self, patch_flags): ("enrollment not passed", {}, 0, "flags-fallback-value", 1), ("enrolled", {"$feature_enrollment/beta-feature": "true"}, 0, True, 0), ("opted out", {"$feature_enrollment/beta-feature": False}, 100, False, 0), + ( + "not a true value", + {"$feature_enrollment/beta-feature": 1}, + 100, + False, + 0, + ), ] ) def test_feature_enrollment_flag( From fffef4d465e3426e1e34623d3ea73d78aaf1e037 Mon Sep 17 00:00:00 2001 From: Shy Alter Date: Wed, 4 Nov 2026 14:32:35 +0100 Subject: [PATCH 3/3] fix(flags): send group flags with feature enrollment to the flags service For a group flag, local evaluation passes group properties, but the flags service reads enrollment from the person. Local evaluation now treats a group flag with feature enrollment as unresolved, so it falls back to /flags. Co-Authored-By: Claude Opus 5.5 Generated-By: PostHog Desktop Task-Id: fecca688-37ac-44b6-a1b5-27e11cb0749b --- posthog/feature_flags.py | 5 ++++ posthog/test/test_feature_flags.py | 43 ++++++++++++++++++++++++++---- 2 files changed, 43 insertions(+), 5 deletions(-) diff --git a/posthog/feature_flags.py b/posthog/feature_flags.py index a2790b46a..6a16ee319 100644 --- a/posthog/feature_flags.py +++ b/posthog/feature_flags.py @@ -494,6 +494,11 @@ def match_feature_flag_properties( if flag_filters.get("feature_enrollment") is True: enrollment_key = f"$feature_enrollment/{flag.get('key')}" + if flag_filters.get("aggregation_group_type_index") is not None: + raise InconclusiveMatchError( + "Group flag has feature enrollment, which reads person properties", + reason=UnresolvedFlagReason.UNSUPPORTED_DEFINITION, + ) if enrollment_key not in properties: raise InconclusiveMatchError( f"Flag has feature enrollment and '{enrollment_key}' was not passed", diff --git a/posthog/test/test_feature_flags.py b/posthog/test/test_feature_flags.py index 6b64f5889..ff1d56593 100644 --- a/posthog/test/test_feature_flags.py +++ b/posthog/test/test_feature_flags.py @@ -1194,20 +1194,43 @@ def test_experience_continuity_flag_not_evaluated_locally(self, patch_flags): @parameterized.expand( [ - ("enrollment not passed", {}, 0, "flags-fallback-value", 1), - ("enrolled", {"$feature_enrollment/beta-feature": "true"}, 0, True, 0), - ("opted out", {"$feature_enrollment/beta-feature": False}, 100, False, 0), + ("enrollment not passed", {}, 0, "flags-fallback-value", 1, False), + ( + "enrolled", + {"$feature_enrollment/beta-feature": "true"}, + 0, + True, + 0, + False, + ), + ( + "opted out", + {"$feature_enrollment/beta-feature": False}, + 100, + False, + 0, + False, + ), ( "not a true value", {"$feature_enrollment/beta-feature": 1}, 100, False, 0, + False, + ), + ( + "group flag", + {"$feature_enrollment/beta-feature": False}, + 100, + "flags-fallback-value", + 1, + True, ), ] ) def test_feature_enrollment_flag( - self, _name, person_properties, rollout, expected, flags_calls + self, _name, person_properties, rollout, expected, flags_calls, group ): client = Client(FAKE_TEST_API_KEY, secret_key="test") client.feature_flags = [ @@ -1218,15 +1241,25 @@ def test_feature_enrollment_flag( "filters": { "groups": [{"properties": [], "rollout_percentage": rollout}], "feature_enrollment": True, + "aggregation_group_type_index": 0 if group else None, }, } ] + client.group_type_mapping = {"0": "company"} with mock.patch("posthog.client.flags") as patch_flags: patch_flags.return_value = { "featureFlags": {"beta-feature": "flags-fallback-value"} } value = client.get_feature_flag( - "beta-feature", "distinct_id", person_properties=person_properties + "beta-feature", + "distinct_id", + person_properties=person_properties, + groups={"company": "acme"} if group else None, + group_properties={ + "company": {"$feature_enrollment/beta-feature": "true"} + } + if group + else None, ) self.assertEqual((value, patch_flags.call_count), (expected, flags_calls))