From 07588b42152026de19effd5b438e5684ea57f4c5 Mon Sep 17 00:00:00 2001 From: Kayvan Zahiri <123409429+Kayvan-Zahiri@users.noreply.github.com> Date: Thu, 5 Nov 2026 11:11:52 -0800 Subject: [PATCH 1/2] fix(flags): canonicalize numeric group keys for local bucketing --- .../canonical-group-key-bucketing.md | 5 ++ posthog/client.py | 3 +- posthog/feature_flags.py | 13 ++- posthog/test/test_feature_flags.py | 80 +++++++++++++++++++ 4 files changed, 99 insertions(+), 2 deletions(-) create mode 100644 .sampo/changesets/canonical-group-key-bucketing.md diff --git a/.sampo/changesets/canonical-group-key-bucketing.md b/.sampo/changesets/canonical-group-key-bucketing.md new file mode 100644 index 000000000..67fe94098 --- /dev/null +++ b/.sampo/changesets/canonical-group-key-bucketing.md @@ -0,0 +1,5 @@ +--- +posthog: patch +--- + +Use canonical numeric group keys for local feature-flag bucketing and fall back to remote evaluation for unsupported key types. diff --git a/posthog/client.py b/posthog/client.py index 87ba50705..781d2ecf9 100644 --- a/posthog/client.py +++ b/posthog/client.py @@ -86,6 +86,7 @@ InconclusiveMatchError, RequiresServerEvaluation, _get_definition_unresolved_reason, + _group_key_to_string, match_feature_flag_properties, resolve_bucketing_value, ) @@ -3943,7 +3944,7 @@ def _compute_flag_locally( reason=UnresolvedFlagReason.MISSING_CONTEXT, ) focused_group_properties = group_properties[group_name] - group_key = groups[group_name] + group_key = _group_key_to_string(groups[group_name]) return match_feature_flag_properties( feature_flag, group_key, diff --git a/posthog/feature_flags.py b/posthog/feature_flags.py index 6a16ee319..055e70e83 100644 --- a/posthog/feature_flags.py +++ b/posthog/feature_flags.py @@ -552,7 +552,7 @@ def match_feature_flag_properties( ) continue effective_properties = group_properties[group_name] - effective_bucketing = groups[group_name] + effective_bucketing = _group_key_to_string(groups[group_name]) else: effective_properties = properties effective_bucketing = bucketing_value @@ -801,6 +801,17 @@ def _json_value_to_string(value, reason: UnresolvedFlagReason) -> str: ) +def _group_key_to_string(value) -> str: + if isinstance(value, str): + return value + if isinstance(value, (int, float)) and not isinstance(value, bool): + return _json_value_to_string(value, UnresolvedFlagReason.MISSING_CONTEXT) + raise InconclusiveMatchError( + "Group keys must be strings or finite numbers", + reason=UnresolvedFlagReason.MISSING_CONTEXT, + ) + + def _value_to_string(value, reason: UnresolvedFlagReason) -> str: if isinstance(value, str): return value diff --git a/posthog/test/test_feature_flags.py b/posthog/test/test_feature_flags.py index ff1d56593..e402fe072 100644 --- a/posthog/test/test_feature_flags.py +++ b/posthog/test/test_feature_flags.py @@ -122,6 +122,86 @@ def test_missing_nested_cohort_always_requires_server_evaluation(self): ) +class TestGroupKeyBucketing(unittest.TestCase): + def setUp(self): + self.client = Client(FAKE_TEST_API_KEY, send=False) + self.client.group_type_mapping = {"0": "company"} + + def tearDown(self): + self.client.shutdown() + + def set_group_flag(self, mixed=False, rollout=50): + condition = {"properties": [], "rollout_percentage": rollout} + filters = {"groups": [condition]} + if mixed: + condition["aggregation_group_type_index"] = 0 + else: + filters["aggregation_group_type_index"] = 0 + self.client.feature_flags = [ + {"id": 1, "key": "group-beta", "active": True, "filters": filters} + ] + + @parameterized.expand([(False,), (True,)]) + @mock.patch("posthog.client.flags") + def test_numeric_group_keys_use_server_representation(self, mixed, patch_flags): + self.set_group_flag(mixed) + # For this flag, "0.00001" hashes below 50%, but Python's "1e-05" + # hashes above it. Integer keys should keep their existing bucketing. + for group_key in (0.00001, "0.00001", 42, "42"): + with self.subTest(group_key=group_key): + self.assertTrue( + self.client.get_feature_flag( + "group-beta", + "user-1", + groups={"company": group_key}, + only_evaluate_locally=True, + send_feature_flag_events=False, + ) + ) + flags = self.client.evaluate_flags( + "user-1", + groups={"company": group_key}, + only_evaluate_locally=True, + ) + self.assertTrue(flags.get_flag("group-beta")) + patch_flags.assert_not_called() + + @parameterized.expand([(False,), (True,)]) + @mock.patch("posthog.client.flags") + def test_unsupported_group_keys_require_remote_evaluation(self, mixed, patch_flags): + self.set_group_flag(mixed, rollout=100) + patch_flags.return_value = {"featureFlags": {"group-beta": "remote"}} + for group_key in (True, False, None, [], {}, float("inf"), float("nan")): + with self.subTest(group_key=group_key): + self.assertIsNone( + self.client.get_feature_flag( + "group-beta", + "user-1", + groups={"company": group_key}, + only_evaluate_locally=True, + send_feature_flag_events=False, + ) + ) + flags = self.client.evaluate_flags( + "user-1", + groups={"company": group_key}, + only_evaluate_locally=True, + ) + self.assertNotIn("group-beta", flags.keys) + patch_flags.assert_not_called() + self.assertEqual( + self.client.get_feature_flag( + "group-beta", + "user-1", + groups={"company": group_key}, + send_feature_flag_events=False, + ), + "remote", + ) + patch_flags.assert_called_once() + patch_flags.reset_mock() + + class TestNumericOrderingLocalEvaluation(unittest.TestCase): def setUp(self): self.client = Client(FAKE_TEST_API_KEY) From 4eaf94a19051f21075785b554861a8876487c86f Mon Sep 17 00:00:00 2001 From: Anna Garcia Date: Wed, 18 Nov 2026 13:36:42 -0500 Subject: [PATCH 2/2] fix(flags): keep local bucketing for numbers.Integral group keys NumPy and other registered Integral types previously bucketed as their decimal string; restrict-to-int would have turned them inconclusive. Co-Authored-By: Claude Opus 5.5 --- posthog/feature_flags.py | 5 ++++- posthog/test/test_feature_flags.py | 17 ++++++++++++++++- 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/posthog/feature_flags.py b/posthog/feature_flags.py index 11cd2edd6..6a2e98693 100644 --- a/posthog/feature_flags.py +++ b/posthog/feature_flags.py @@ -4,6 +4,7 @@ import json import logging import math +import numbers import re import warnings from decimal import Decimal @@ -1013,7 +1014,9 @@ def _json_object_to_string(value: dict, reason: UnresolvedFlagReason) -> str: def _group_key_to_string(value) -> str: if isinstance(value, str): return value - if isinstance(value, (int, float)) and not isinstance(value, bool): + if not isinstance(value, bool) and isinstance(value, numbers.Integral): + return str(int(value)) + if isinstance(value, float): return _json_value_to_string(value, UnresolvedFlagReason.MISSING_CONTEXT) raise InconclusiveMatchError( "Group keys must be strings or finite numbers", diff --git a/posthog/test/test_feature_flags.py b/posthog/test/test_feature_flags.py index ea679836e..ac249134a 100644 --- a/posthog/test/test_feature_flags.py +++ b/posthog/test/test_feature_flags.py @@ -1,5 +1,6 @@ import datetime import hashlib +import numbers import threading import unittest @@ -122,6 +123,20 @@ def test_missing_nested_cohort_always_requires_server_evaluation(self): ) +class _NumpyLikeInt: + def __init__(self, value): + self.value = value + + def __int__(self): + return self.value + + def __str__(self): + return f"np.int64({self.value})" + + +numbers.Integral.register(_NumpyLikeInt) + + class TestGroupKeyBucketing(unittest.TestCase): def setUp(self): self.client = Client(FAKE_TEST_API_KEY, send=False) @@ -147,7 +162,7 @@ def test_numeric_group_keys_use_server_representation(self, mixed, patch_flags): self.set_group_flag(mixed) # For this flag, "0.00001" hashes below 50%, but Python's "1e-05" # hashes above it. Integer keys should keep their existing bucketing. - for group_key in (0.00001, "0.00001", 42, "42"): + for group_key in (0.00001, "0.00001", 42, "42", _NumpyLikeInt(42)): with self.subTest(group_key=group_key): self.assertTrue( self.client.get_feature_flag(