From e49223fef272dc96bdc586fd0345075221c30b55 Mon Sep 17 00:00:00 2001 From: Markus Urbanczyk Date: Fri, 14 Aug 2026 19:28:36 +0200 Subject: [PATCH 1/3] Fix `package` on Fedora 44 by ignoring unexpected `Upgrades` DNF5 header Signed-off-by: Markus Urbanczyk Signed-off-by: Nils Ballmann --- lib/puppet/provider/package/yum.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/puppet/provider/package/yum.rb b/lib/puppet/provider/package/yum.rb index 27af23513b..91333a75ad 100644 --- a/lib/puppet/provider/package/yum.rb +++ b/lib/puppet/provider/package/yum.rb @@ -133,7 +133,7 @@ def self.check_updates(disablerepo, enablerepo, disableexcludes) def self.parse_updates(str) # Strip off all content that contains Obsoleting, Security: or Update body = str.partition(/^(Obsoleting|Security:|Update)/).first - + body = body.gsub(/^Upgrades.*?$/m, '') updates = Hash.new { |h, k| h[k] = [] } body.split(/^\s*\n/).each do |line| From 5f6aef59f4e8170f35488211b921487eb7e3b371 Mon Sep 17 00:00:00 2001 From: Nils Ballmann Date: Mon, 16 Nov 2026 11:26:12 +0100 Subject: [PATCH 2/3] Add tests to avoid regressions around unexpected `Upgrades` DNF5 header Signed-off-by: Nils Ballmann --- .../yum-check-update-with-updates-header.txt | 4 +++ ...um-check-update-without-updates-header.txt | 3 +++ spec/unit/provider/package/yum_spec.rb | 26 +++++++++++++++++++ 3 files changed, 33 insertions(+) create mode 100644 spec/fixtures/unit/provider/package/yum/yum-check-update-with-updates-header.txt create mode 100644 spec/fixtures/unit/provider/package/yum/yum-check-update-without-updates-header.txt diff --git a/spec/fixtures/unit/provider/package/yum/yum-check-update-with-updates-header.txt b/spec/fixtures/unit/provider/package/yum/yum-check-update-with-updates-header.txt new file mode 100644 index 0000000000..38b913cd11 --- /dev/null +++ b/spec/fixtures/unit/provider/package/yum/yum-check-update-with-updates-header.txt @@ -0,0 +1,4 @@ +Updating and loading repositories: +Repositories loaded. +Upgrades (available for reinstall, available for upgrade) +curl.x86_64 8.18.0-10.fc44 updates diff --git a/spec/fixtures/unit/provider/package/yum/yum-check-update-without-updates-header.txt b/spec/fixtures/unit/provider/package/yum/yum-check-update-without-updates-header.txt new file mode 100644 index 0000000000..b4f531802b --- /dev/null +++ b/spec/fixtures/unit/provider/package/yum/yum-check-update-without-updates-header.txt @@ -0,0 +1,3 @@ +Updating and loading repositories: +Repositories loaded. +curl.x86_64 8.15.0-10.fc43 updates diff --git a/spec/unit/provider/package/yum_spec.rb b/spec/unit/provider/package/yum_spec.rb index 40325b4348..0729782dd6 100644 --- a/spec/unit/provider/package/yum_spec.rb +++ b/spec/unit/provider/package/yum_spec.rb @@ -278,6 +278,32 @@ end end + context "without updates header" do + let(:check_update) { File.read(my_fixture("yum-check-update-without-updates-header.txt")) } + let(:output) { described_class.parse_updates(check_update) } + + it "parses correctly formatted entries" do + expect(output['curl']).to eq([{:name => 'curl', :epoch => '0', :version => '8.15.0', :release => '10.fc43', :arch => 'x86_64'}]) + end + + it "ignores all mentions of updates header" do + expect(output).not_to include("Upgrades (available for reinstall, available for upgrade)") + end + end + + context "with updates header" do + let(:check_update) { File.read(my_fixture("yum-check-update-with-updates-header.txt")) } + let(:output) { described_class.parse_updates(check_update) } + + it "parses correctly formatted entries" do + expect(output['curl']).to eq([{:name => 'curl', :epoch => '0', :version => '8.18.0', :release => '10.fc44', :arch => 'x86_64'}]) + end + + it "ignores all mentions of updates header" do + expect(output).not_to include("Upgrades (available for reinstall, available for upgrade)") + end + end + context "with subscription manager enabled " do let(:check_update) { File.read(my_fixture("yum-check-update-subscription-manager.txt")) } let(:output) { described_class.parse_updates(check_update) } From dee1594d476476c8525c9d350d2c67103368b292 Mon Sep 17 00:00:00 2001 From: Nils Ballmann Date: Mon, 16 Nov 2026 13:06:11 +0100 Subject: [PATCH 3/3] Add aditional bare Updates header test case Co-authored-by: Stefano Tondo Signed-off-by: Nils Ballmann --- .../yum/yum-check-update-with-bare-updates-header.txt | 4 ++++ spec/unit/provider/package/yum_spec.rb | 10 ++++++++++ 2 files changed, 14 insertions(+) create mode 100644 spec/fixtures/unit/provider/package/yum/yum-check-update-with-bare-updates-header.txt diff --git a/spec/fixtures/unit/provider/package/yum/yum-check-update-with-bare-updates-header.txt b/spec/fixtures/unit/provider/package/yum/yum-check-update-with-bare-updates-header.txt new file mode 100644 index 0000000000..313dc3c36a --- /dev/null +++ b/spec/fixtures/unit/provider/package/yum/yum-check-update-with-bare-updates-header.txt @@ -0,0 +1,4 @@ +Updating and loading repositories: +Repositories loaded. +Upgrades +curl.x86_64 8.18.0-14.fc44 updates diff --git a/spec/unit/provider/package/yum_spec.rb b/spec/unit/provider/package/yum_spec.rb index 0729782dd6..03911abe11 100644 --- a/spec/unit/provider/package/yum_spec.rb +++ b/spec/unit/provider/package/yum_spec.rb @@ -304,6 +304,16 @@ end end + context "with bare updates header (dnf5 5.4)" do + let(:check_update) { File.read(my_fixture("yum-check-update-with-bare-updates-header.txt")) } + let(:output) { described_class.parse_updates(check_update) } + + it "parses only the package entries" do + expect(output.keys).to contain_exactly('curl', 'curl.x86_64') + expect(output['curl']).to eq([{:name => 'curl', :epoch => '0', :version => '8.18.0', :release => '14.fc44', :arch => 'x86_64'}]) + end + end + context "with subscription manager enabled " do let(:check_update) { File.read(my_fixture("yum-check-update-subscription-manager.txt")) } let(:output) { described_class.parse_updates(check_update) }