From 40eb8ae407e76aae6b096c724180b18e531baa09 Mon Sep 17 00:00:00 2001 From: "slominskir-coding-agent[bot]" <335168828+slominskir-coding-agent[bot]@users.noreply.github.com> Date: Wed, 7 Oct 2026 14:56:30 -0400 Subject: [PATCH] Fix TimeUtilTest failing on Wednesdays encodeRangeMatchesRangesRelativeToToday expected the seven days ending today to encode as past7days. Weeks start on Wednesday, so on a Wednesday those seven days are also last week, which encodeRange checks first and returns as 1week. The test failed every Wednesday. That assertion moves to its own test, which records the quirk: 1week on Wednesdays, past7days on other days. The relative-to-today test checks past3days and past10days instead, which never collide with a week. Co-Authored-By: Claude Opus 5.5 --- .../smoothness/business/util/TimeUtilTest.java | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/smoothness-weblib/src/test/java/org/jlab/smoothness/business/util/TimeUtilTest.java b/smoothness-weblib/src/test/java/org/jlab/smoothness/business/util/TimeUtilTest.java index 271cd47..f0516e5 100644 --- a/smoothness-weblib/src/test/java/org/jlab/smoothness/business/util/TimeUtilTest.java +++ b/smoothness-weblib/src/test/java/org/jlab/smoothness/business/util/TimeUtilTest.java @@ -420,7 +420,20 @@ void encodeRangeMatchesRangesRelativeToToday() { "1year", TimeUtil.encodeRange(TimeUtil.addYears(yearStart, -1), yearStart, false, null, null)); assertEquals( - "past7days", TimeUtil.encodeRange(TimeUtil.addDays(today, -7), today, false, null, null)); + "past3days", TimeUtil.encodeRange(TimeUtil.addDays(today, -3), today, false, null, null)); + assertEquals( + "past10days", TimeUtil.encodeRange(TimeUtil.addDays(today, -10), today, false, null, null)); + } + + @Test + void encodeRangeOfThePastSevenDaysIsLastWeekOnWednesdays() { + Date today = TimeUtil.startOfDay(new Date(), Calendar.getInstance()); + boolean wednesday = TimeUtil.startOfWeek(today, Calendar.WEDNESDAY).equals(today); + + // Weeks start on Wednesday, and last week is checked before the past seven days. + assertEquals( + wednesday ? "1week" : "past7days", + TimeUtil.encodeRange(TimeUtil.addDays(today, -7), today, false, null, null)); } @Test