From ef310c5d7ad19428d2b7bbf5e33b026eec85f436 Mon Sep 17 00:00:00 2001 From: Derek Campbell Date: Sun, 4 Oct 2026 21:27:32 +0100 Subject: [PATCH 1/3] Adopt central ShellCheck workflow Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> --- .github/workflows/ci.yml | 15 ++++----------- lint.sh | 4 ++-- 2 files changed, 6 insertions(+), 13 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7519a53..811cf68 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -13,17 +13,10 @@ permissions: jobs: lint: name: Lint (shellcheck) - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v4 - - name: Install shellcheck - run: | - sudo apt-get update - sudo apt-get install -y shellcheck - - name: Lint lessons - run: shellcheck lessons/*.sh - - name: Lint tests - run: shellcheck --shell=bash tests/*.bats + uses: DevOpsDerek/workflows/.github/workflows/lint/shell.yml@cd4f07509e9efb0c498217c3be352e762bd0c149 + with: + shellcheck-version: 0.10.0 + working-directory: . test: name: Test (bats-core) diff --git a/lint.sh b/lint.sh index 337294e..f15e12b 100755 --- a/lint.sh +++ b/lint.sh @@ -6,8 +6,8 @@ if ! command -v shellcheck &>/dev/null; then exit 1 fi -echo "Running shellcheck on lessons/..." -shellcheck lessons/*.sh +echo "Running shellcheck on scripts and lessons/..." +shellcheck ./*.sh lessons/*.sh echo "Running shellcheck on tests/..." shellcheck --shell=bash tests/*.bats echo "All files passed shellcheck." From 898dbc50501579b1067d679a61d5477363f9ee1f Mon Sep 17 00:00:00 2001 From: Derek Campbell Date: Sun, 4 Oct 2026 21:31:10 +0100 Subject: [PATCH 2/3] Use top-level central ShellCheck entrypoint Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 811cf68..1b618cb 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -13,7 +13,7 @@ permissions: jobs: lint: name: Lint (shellcheck) - uses: DevOpsDerek/workflows/.github/workflows/lint/shell.yml@cd4f07509e9efb0c498217c3be352e762bd0c149 + uses: DevOpsDerek/workflows/.github/workflows/lint-shell.yml@c4ac3847334c8944a48619ae4f3f0d622f4a074b with: shellcheck-version: 0.10.0 working-directory: . From 6434cfafbbcd08779d18825636714cfe9b5b771d Mon Sep 17 00:00:00 2001 From: Derek Campbell Date: Sun, 4 Oct 2026 21:32:57 +0100 Subject: [PATCH 3/3] Pin merged central ShellCheck workflow Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1b618cb..4d8180c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -13,7 +13,7 @@ permissions: jobs: lint: name: Lint (shellcheck) - uses: DevOpsDerek/workflows/.github/workflows/lint-shell.yml@c4ac3847334c8944a48619ae4f3f0d622f4a074b + uses: DevOpsDerek/workflows/.github/workflows/lint-shell.yml@35ec3f531b5eb0f0f42f232f23e1dc5735e36c35 with: shellcheck-version: 0.10.0 working-directory: .