Let a regression fixer fix the module's other earlier tests in the same fix

In a shrinq render one functionality's new component broke the earlier
functionalities' conformance tests (their Spring context scans the whole
package), and each earlier test folder was fixed in its own fixer session
with its own test runs, for the same cause. When the failing tests belong to
an earlier functionality, the fixer may now write the current module's whole
conformance tests folder, and the folder is sent to the server as
writable_module_tests_folder.

Author: VitjanZ

render_machine/actions/fix_conformance_test.py

@@ -180,6 +180,17 @@ def _agents_for_current_tests(render_context: RenderContext) -> ConformanceFixAg
                 conformance_tests_folder=FixConformanceTest._writable_conformance_tests_folder(render_context),
                 readable_tests_folders=FixConformanceTest._readable_conformance_tests_folders(render_context),
                 plain_modules_folder=agent_tools.rendered_modules_folder(render_context),
+                writable_module_tests_folder=(
+                    os.path.normpath(
+                        os.path.abspath(
+                            render_context.conformance_tests.get_module_conformance_tests_folder(
+                                render_context.module_name
+                            )
+                        )
+                    )
+                    if FixConformanceTest._is_regression(render_context)
+                    else ""
+                ),
             )
         return ctx.conformance_fix_agents
 
@@ -248,6 +259,7 @@ def _common_params(render_context: RenderContext, agents: ConformanceFixAgents)
             "build_folder": os.path.normpath(os.path.abspath(render_context.build_folder)),
             "conformance_tests_folder": agents.conformance_tests_folder,
             **agent_tools.modules_layout_params(render_context),
+            "writable_module_tests_folder": agents.writable_module_tests_folder,
             "readable_conformance_tests_folders": agents.readable_tests_folders,
             "conformance_tests_script_content": FixUnitTests._read_script(render_context.conformance_tests_script),
             "prepare_environment_script_content": FixUnitTests._read_script(render_context.prepare_environment_script),

render_machine/conformance_fix_conversation.py

@@ -86,7 +86,11 @@ def __init__(self, render_context, agents: ConformanceFixAgents, fixer_params: d
         self.build_folder = os.path.normpath(os.path.abspath(render_context.build_folder))
         self.fixer_workspace = agent_tools.AgentWorkspace(
             build_folder=self.build_folder,
-            writable_folders=[self.build_folder, agents.conformance_tests_folder],
+            writable_folders=[
+                self.build_folder,
+                agents.conformance_tests_folder,
+                *([agents.writable_module_tests_folder] if agents.writable_module_tests_folder else []),
+            ],
             readable_folders=[agents.plain_modules_folder, *agents.readable_tests_folders],
             readable_log_paths=agents.readable_log_paths,
             tool_result_cache=agents.fixer_tool_result_cache,

render_machine/render_types.py

@@ -113,6 +113,9 @@ class ConformanceFixAgents:
     readable_tests_folders: list[str] = field(default_factory=list)
     # The rendered modules folder (plain_modules): both agents may read every module's code and tests.
     plain_modules_folder: str = ""
+    # For a regression (earlier tests broken by the current functionality): the current module's conformance tests
+    # folder, which the fixer may write so it fixes the other earlier tests that share the cause in the same fix.
+    writable_module_tests_folder: str = ""
     fixer: AgentSessionState = field(default_factory=AgentSessionState)
     reviewer: AgentSessionState = field(default_factory=AgentSessionState)
     # Content of every file the current fix changed, from before the fix (None: the file did not exist), so the fix

tests/test_conformance_fix_conversation.py

@@ -467,6 +467,29 @@ def test_agents_read_every_rendered_module_and_are_told_the_layout(project):
     assert start_params["required_module_names"] == ["base"]
 
 
+@pytest.mark.parametrize("regression", [True, False])
+def test_a_regression_fixer_may_fix_the_other_earlier_tests_of_the_module(project, regression):
+    sibling = project.root / "conformance" / "login" / "test_login.py"
+    sibling.parent.mkdir()
+    sibling.write_text("OLD SETUP\n")
+    api = ScriptedAgentAPI(
+        fixer_turns=[[write(str(sibling), "NEW SETUP\n"), write("app.py", "v1\n")], [submit_fix()]],
+        reviewer_turns=[[review("approve")]],
+    )
+    render_context = make_render_context(project, api, testing_frid="1", frid="2" if regression else "1")
+
+    run_fix(render_context)
+
+    result = api.of("continue", conversation.FIXER_TASK)[0][3][0]["output"]
+    [(_, _, _, start_params)] = api.of("start", conversation.FIXER_TASK)
+    if regression:
+        assert sibling.read_text() == "NEW SETUP\n"
+        assert start_params["writable_module_tests_folder"] == str(project.root / "conformance")
+    else:
+        assert result.startswith("Error: write access denied") and sibling.read_text() == "OLD SETUP\n"
+        assert start_params["writable_module_tests_folder"] == ""
+
+
 def test_reviewer_last_verdict_counts_and_the_next_review_starts_a_new_session(project):
     api = ScriptedAgentAPI(
         fixer_turns=[[write("app.py", "v1\n")], [submit_fix()], [write("app.py", "v2\n")], [submit_fix()]],